* [PATCH net-next v1 1/1] net: dsa: hellcreek: Replace kernel.h with what is used
@ 2024-06-06 16:15 Andy Shevchenko
2024-06-06 17:11 ` Kurt Kanzenbach
2024-06-10 12:20 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Andy Shevchenko @ 2024-06-06 16:15 UTC (permalink / raw)
To: Andy Shevchenko, netdev, linux-kernel
Cc: Kurt Kanzenbach, Andrew Lunn, Florian Fainelli, Vladimir Oltean,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
kernel.h is included solely for some other existing headers.
Include them directly and get rid of kernel.h.
While at it, sort headers alphabetically for easier maintenance.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/net/dsa/hirschmann/hellcreek.h | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/net/dsa/hirschmann/hellcreek.h b/drivers/net/dsa/hirschmann/hellcreek.h
index 6874cb9dc361..9c2ed2ba79da 100644
--- a/drivers/net/dsa/hirschmann/hellcreek.h
+++ b/drivers/net/dsa/hirschmann/hellcreek.h
@@ -12,14 +12,16 @@
#include <linux/bitmap.h>
#include <linux/bitops.h>
+#include <linux/container_of.h>
#include <linux/device.h>
-#include <linux/kernel.h>
-#include <linux/mutex.h>
-#include <linux/workqueue.h>
#include <linux/leds.h>
+#include <linux/mutex.h>
#include <linux/platform_data/hirschmann-hellcreek.h>
#include <linux/ptp_clock_kernel.h>
#include <linux/timecounter.h>
+#include <linux/types.h>
+#include <linux/workqueue.h>
+
#include <net/dsa.h>
#include <net/pkt_sched.h>
--
2.43.0.rc1.1336.g36b5255a03ac
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next v1 1/1] net: dsa: hellcreek: Replace kernel.h with what is used
2024-06-06 16:15 [PATCH net-next v1 1/1] net: dsa: hellcreek: Replace kernel.h with what is used Andy Shevchenko
@ 2024-06-06 17:11 ` Kurt Kanzenbach
2024-06-10 12:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Kurt Kanzenbach @ 2024-06-06 17:11 UTC (permalink / raw)
To: Andy Shevchenko, Andy Shevchenko, netdev, linux-kernel
Cc: Andrew Lunn, Florian Fainelli, Vladimir Oltean, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni
[-- Attachment #1: Type: text/plain, Size: 355 bytes --]
On Thu Jun 06 2024, Andy Shevchenko wrote:
> kernel.h is included solely for some other existing headers.
> Include them directly and get rid of kernel.h.
>
> While at it, sort headers alphabetically for easier maintenance.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Thanks!
Reviewed-by: Kurt Kanzenbach <kurt@linutronix.de>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next v1 1/1] net: dsa: hellcreek: Replace kernel.h with what is used
2024-06-06 16:15 [PATCH net-next v1 1/1] net: dsa: hellcreek: Replace kernel.h with what is used Andy Shevchenko
2024-06-06 17:11 ` Kurt Kanzenbach
@ 2024-06-10 12:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-06-10 12:20 UTC (permalink / raw)
To: Andy Shevchenko
Cc: netdev, linux-kernel, kurt, andrew, f.fainelli, olteanv, davem,
edumazet, kuba, pabeni
Hello:
This patch was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:
On Thu, 6 Jun 2024 19:15:49 +0300 you wrote:
> kernel.h is included solely for some other existing headers.
> Include them directly and get rid of kernel.h.
>
> While at it, sort headers alphabetically for easier maintenance.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> [...]
Here is the summary with links:
- [net-next,v1,1/1] net: dsa: hellcreek: Replace kernel.h with what is used
https://git.kernel.org/netdev/net-next/c/c917b26e1686
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-06-10 12:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-06 16:15 [PATCH net-next v1 1/1] net: dsa: hellcreek: Replace kernel.h with what is used Andy Shevchenko
2024-06-06 17:11 ` Kurt Kanzenbach
2024-06-10 12:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).