* [PATCH net] net: pse-pd: Kconfig: Fix missing firmware loader config select
@ 2024-06-20 9:57 Kory Maincent
2024-06-20 14:26 ` Andrew Lunn
2024-06-21 10:40 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Kory Maincent @ 2024-06-20 9:57 UTC (permalink / raw)
To: Andrew Lunn, Kory Maincent (Dent Project), Jakub Kicinski, netdev,
linux-kernel
Cc: kernel test robot, thomas.petazzoni, Oleksij Rempel,
David S. Miller, Eric Dumazet, Paolo Abeni
Selecting FW_UPLOAD is not sufficient as it allows the firmware loader
API to be built as a module alongside the pd692x0 driver built as builtin.
Add select FW_LOADER to fix this issue.
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202406200632.hSChnX0g-lkp@intel.com/
Fixes: 9a9938451890 ("net: pse-pd: Add PD692x0 PSE controller driver")
Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
---
drivers/net/pse-pd/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/pse-pd/Kconfig b/drivers/net/pse-pd/Kconfig
index 577ea904b3d9..7fab916a7f46 100644
--- a/drivers/net/pse-pd/Kconfig
+++ b/drivers/net/pse-pd/Kconfig
@@ -23,6 +23,7 @@ config PSE_REGULATOR
config PSE_PD692X0
tristate "PD692X0 PSE controller"
depends on I2C
+ select FW_LOADER
select FW_UPLOAD
help
This module provides support for PD692x0 regulator based Ethernet
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] net: pse-pd: Kconfig: Fix missing firmware loader config select
2024-06-20 9:57 [PATCH net] net: pse-pd: Kconfig: Fix missing firmware loader config select Kory Maincent
@ 2024-06-20 14:26 ` Andrew Lunn
2024-06-21 10:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2024-06-20 14:26 UTC (permalink / raw)
To: Kory Maincent
Cc: Jakub Kicinski, netdev, linux-kernel, kernel test robot,
thomas.petazzoni, Oleksij Rempel, David S. Miller, Eric Dumazet,
Paolo Abeni
On Thu, Jun 20, 2024 at 11:57:50AM +0200, Kory Maincent wrote:
> Selecting FW_UPLOAD is not sufficient as it allows the firmware loader
> API to be built as a module alongside the pd692x0 driver built as builtin.
> Add select FW_LOADER to fix this issue.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202406200632.hSChnX0g-lkp@intel.com/
> Fixes: 9a9938451890 ("net: pse-pd: Add PD692x0 PSE controller driver")
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] net: pse-pd: Kconfig: Fix missing firmware loader config select
2024-06-20 9:57 [PATCH net] net: pse-pd: Kconfig: Fix missing firmware loader config select Kory Maincent
2024-06-20 14:26 ` Andrew Lunn
@ 2024-06-21 10:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-06-21 10:40 UTC (permalink / raw)
To: Kory Maincent
Cc: andrew, kuba, netdev, linux-kernel, lkp, thomas.petazzoni,
o.rempel, davem, edumazet, pabeni
Hello:
This patch was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:
On Thu, 20 Jun 2024 11:57:50 +0200 you wrote:
> Selecting FW_UPLOAD is not sufficient as it allows the firmware loader
> API to be built as a module alongside the pd692x0 driver built as builtin.
> Add select FW_LOADER to fix this issue.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202406200632.hSChnX0g-lkp@intel.com/
> Fixes: 9a9938451890 ("net: pse-pd: Add PD692x0 PSE controller driver")
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
>
> [...]
Here is the summary with links:
- [net] net: pse-pd: Kconfig: Fix missing firmware loader config select
https://git.kernel.org/netdev/net/c/7eadf50095bc
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-06-21 10:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-20 9:57 [PATCH net] net: pse-pd: Kconfig: Fix missing firmware loader config select Kory Maincent
2024-06-20 14:26 ` Andrew Lunn
2024-06-21 10:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).