* [PATCH net] netlink: specs: Fix pse-set command attributes
@ 2024-06-21 13:00 Kory Maincent
2024-06-21 14:41 ` Donald Hunter
2024-06-23 9:10 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Kory Maincent @ 2024-06-21 13:00 UTC (permalink / raw)
To: Jakub Kicinski, Kory Maincent (Dent Project), Andrew Lunn, netdev,
linux-kernel
Cc: Oleksij Rempel, thomas.petazzoni, Donald Hunter, David S. Miller,
Eric Dumazet, Paolo Abeni
Not all PSE attributes are used for the pse-set netlink command.
Select only the ones used by ethtool.
Fixes: f8586411e40e ("netlink: specs: Expand the pse netlink command with PoE interface")
Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
---
Documentation/netlink/specs/ethtool.yaml | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/Documentation/netlink/specs/ethtool.yaml b/Documentation/netlink/specs/ethtool.yaml
index 00dc61358be8..4510e8d1adcb 100644
--- a/Documentation/netlink/specs/ethtool.yaml
+++ b/Documentation/netlink/specs/ethtool.yaml
@@ -1603,7 +1603,7 @@ operations:
attributes:
- header
reply:
- attributes: &pse
+ attributes:
- header
- podl-pse-admin-state
- podl-pse-admin-control
@@ -1620,7 +1620,10 @@ operations:
do:
request:
- attributes: *pse
+ attributes:
+ - header
+ - podl-pse-admin-control
+ - c33-pse-admin-control
-
name: rss-get
doc: Get RSS params.
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] netlink: specs: Fix pse-set command attributes
2024-06-21 13:00 [PATCH net] netlink: specs: Fix pse-set command attributes Kory Maincent
@ 2024-06-21 14:41 ` Donald Hunter
2024-06-23 9:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Donald Hunter @ 2024-06-21 14:41 UTC (permalink / raw)
To: Kory Maincent
Cc: Jakub Kicinski, Andrew Lunn, netdev, linux-kernel, Oleksij Rempel,
thomas.petazzoni, David S. Miller, Eric Dumazet, Paolo Abeni
Kory Maincent <kory.maincent@bootlin.com> writes:
> Not all PSE attributes are used for the pse-set netlink command.
> Select only the ones used by ethtool.
>
> Fixes: f8586411e40e ("netlink: specs: Expand the pse netlink command with PoE interface")
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
Reviewed-by: Donald Hunter <donald.hunter@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] netlink: specs: Fix pse-set command attributes
2024-06-21 13:00 [PATCH net] netlink: specs: Fix pse-set command attributes Kory Maincent
2024-06-21 14:41 ` Donald Hunter
@ 2024-06-23 9:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-06-23 9:10 UTC (permalink / raw)
To: Kory Maincent
Cc: kuba, andrew, netdev, linux-kernel, o.rempel, thomas.petazzoni,
donald.hunter, davem, edumazet, pabeni
Hello:
This patch was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:
On Fri, 21 Jun 2024 15:00:59 +0200 you wrote:
> Not all PSE attributes are used for the pse-set netlink command.
> Select only the ones used by ethtool.
>
> Fixes: f8586411e40e ("netlink: specs: Expand the pse netlink command with PoE interface")
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> ---
> Documentation/netlink/specs/ethtool.yaml | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
Here is the summary with links:
- [net] netlink: specs: Fix pse-set command attributes
https://git.kernel.org/netdev/net/c/42354e3c3150
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-06-23 9:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-21 13:00 [PATCH net] netlink: specs: Fix pse-set command attributes Kory Maincent
2024-06-21 14:41 ` Donald Hunter
2024-06-23 9:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).