From: patchwork-bot+netdevbpf@kernel.org
To: Neal Cardwell <ncardwell.sw@gmail.com>
Cc: davem@davemloft.net, kuba@kernel.org, edumazet@google.com,
netdev@vger.kernel.org, ncardwell@google.com, ycheng@google.com
Subject: Re: [PATCH net] tcp: fix tcp_rcv_fastopen_synack() to enter TCP_CA_Loss for failed TFO
Date: Wed, 26 Jun 2024 01:10:28 +0000 [thread overview]
Message-ID: <171936422841.4196.14500455106305455588.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20240624144323.2371403-1-ncardwell.sw@gmail.com>
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 24 Jun 2024 14:43:23 +0000 you wrote:
> From: Neal Cardwell <ncardwell@google.com>
>
> Testing determined that the recent commit 9e046bb111f1 ("tcp: clear
> tp->retrans_stamp in tcp_rcv_fastopen_synack()") has a race, and does
> not always ensure retrans_stamp is 0 after a TFO payload retransmit.
>
> If transmit completion for the SYN+data skb happens after the client
> TCP stack receives the SYNACK (which sometimes happens), then
> retrans_stamp can erroneously remain non-zero for the lifetime of the
> connection, causing a premature ETIMEDOUT later.
>
> [...]
Here is the summary with links:
- [net] tcp: fix tcp_rcv_fastopen_synack() to enter TCP_CA_Loss for failed TFO
https://git.kernel.org/netdev/net/c/5dfe9d273932
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2024-06-26 1:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-24 14:43 [PATCH net] tcp: fix tcp_rcv_fastopen_synack() to enter TCP_CA_Loss for failed TFO Neal Cardwell
2024-06-26 1:10 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171936422841.4196.14500455106305455588.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=ncardwell.sw@gmail.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).