From: patchwork-bot+netdevbpf@kernel.org
To: Stanislav Fomichev <sdf@fomichev.me>
Cc: bpf@vger.kernel.org, netdev@vger.kernel.org, ast@kernel.org,
daniel@iogearbox.net, andrii@kernel.org, martin.lau@linux.dev,
song@kernel.org, yhs@fb.com, john.fastabend@gmail.com,
kpsingh@kernel.org, haoluo@google.com, jolsa@kernel.org,
mail@arctic-alpaca.de, magnus.karlsson@gmail.com,
maciej.fijalkowski@intel.com
Subject: Re: [PATCH bpf-next] xsk: Try to make xdp_umem_reg extension a bit more future-proof
Date: Tue, 30 Jul 2024 22:20:31 +0000 [thread overview]
Message-ID: <172237803156.26065.5548946293304661200.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20240726222048.1397869-1-sdf@fomichev.me>
Hello:
This patch was applied to bpf/bpf-next.git (master)
by Martin KaFai Lau <martin.lau@kernel.org>:
On Fri, 26 Jul 2024 15:20:48 -0700 you wrote:
> We recently found out that extending xsk_umem_reg might be a bit
> complicated due to not enforcing padding to be zero [0]. Add
> a couple of things to make it less error-prone:
> 1. Remove xdp_umem_reg_v2 since its sizeof is the same as xdp_umem_reg
> 2. Add BUILD_BUG_ON that checks that the size of xdp_umem_reg_v1 is less
> than xdp_umem_reg; presumably, when we get to v2, there is gonna
> be a similar line to enforce that sizeof(v2) > sizeof(v1)
> 3. Add BUILD_BUG_ON to make sure the last field plus its size matches
> the overall struct size. The intent is to demonstrate that we don't
> have any lingering padding.
>
> [...]
Here is the summary with links:
- [bpf-next] xsk: Try to make xdp_umem_reg extension a bit more future-proof
https://git.kernel.org/bpf/bpf-next/c/32654bbd6313
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2024-07-30 22:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-26 22:20 [PATCH bpf-next] xsk: Try to make xdp_umem_reg extension a bit more future-proof Stanislav Fomichev
2024-07-30 22:20 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=172237803156.26065.5548946293304661200.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@gmail.com \
--cc=mail@arctic-alpaca.de \
--cc=martin.lau@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=sdf@fomichev.me \
--cc=song@kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).