From: patchwork-bot+netdevbpf@kernel.org
To: Breno Leitao <leitao@debian.org>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, leit@meta.com, clm@fb.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: skbuff: Skip early return in skb_unref when debugging
Date: Thu, 01 Aug 2024 09:30:37 +0000 [thread overview]
Message-ID: <172250463706.8059.2016437225391729013.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20240729104741.370327-1-leitao@debian.org>
Hello:
This patch was applied to netdev/net-next.git (main)
by Paolo Abeni <pabeni@redhat.com>:
On Mon, 29 Jul 2024 03:47:40 -0700 you wrote:
> This patch modifies the skb_unref function to skip the early return
> optimization when CONFIG_DEBUG_NET is enabled. The change ensures that
> the reference count decrement always occurs in debug builds, allowing
> for more thorough checking of SKB reference counting.
>
> Previously, when the SKB's reference count was 1 and CONFIG_DEBUG_NET
> was not set, the function would return early after a memory barrier
> (smp_rmb()) without decrementing the reference count. This optimization
> assumes it's safe to proceed with freeing the SKB without the overhead
> of an atomic decrement from 1 to 0.
>
> [...]
Here is the summary with links:
- [net-next] net: skbuff: Skip early return in skb_unref when debugging
https://git.kernel.org/netdev/net-next/c/c9c0ee5f20c5
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2024-08-01 9:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-29 10:47 [PATCH net-next] net: skbuff: Skip early return in skb_unref when debugging Breno Leitao
2024-07-30 9:38 ` Paolo Abeni
2024-07-30 10:24 ` Breno Leitao
2024-07-30 10:50 ` Florian Westphal
2024-07-30 11:15 ` Paolo Abeni
2024-07-30 14:10 ` Jakub Kicinski
2024-07-30 14:21 ` Eric Dumazet
2024-07-30 14:37 ` Paolo Abeni
2024-07-30 14:48 ` Jakub Kicinski
2024-07-31 11:24 ` Breno Leitao
2024-07-31 11:53 ` Jason Xing
2024-08-01 9:07 ` Paolo Abeni
2024-08-01 9:30 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=172250463706.8059.2016437225391729013.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=clm@fb.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=leit@meta.com \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).