From: patchwork-bot+netdevbpf@kernel.org
To: Christoph Paasch <cpaasch@apple.com>
Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
kuba@kernel.org, davem@davemloft.net, roopa@nvidia.com,
cmtaylor@apple.com
Subject: Re: [PATCH netnext] mpls: Reduce skb re-allocations due to skb_cow()
Date: Sat, 17 Aug 2024 01:00:32 +0000 [thread overview]
Message-ID: <172385643203.3669696.15606969328431040309.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20240815161201.22021-1-cpaasch@apple.com>
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 15 Aug 2024 09:12:01 -0700 you wrote:
> mpls_xmit() needs to prepend the MPLS-labels to the packet. That implies
> one needs to make sure there is enough space for it in the headers.
>
> Calling skb_cow() implies however that one wants to change even the
> playload part of the packet (which is not true for MPLS). Thus, call
> skb_cow_head() instead, which is what other tunnelling protocols do.
>
> [...]
Here is the summary with links:
- [netnext] mpls: Reduce skb re-allocations due to skb_cow()
https://git.kernel.org/netdev/net-next/c/f4ae8420f6eb
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2024-08-17 1:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-15 16:12 [PATCH netnext] mpls: Reduce skb re-allocations due to skb_cow() Christoph Paasch
2024-08-16 11:18 ` Simon Horman
2024-08-16 22:20 ` Christoph Paasch
2024-08-19 9:34 ` Simon Horman
2024-08-17 1:00 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=172385643203.3669696.15606969328431040309.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=cmtaylor@apple.com \
--cc=cpaasch@apple.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).