netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next 1/4] dt-bindings: net: mediatek,net: narrow interrupts per variants
@ 2024-08-18 17:29 Krzysztof Kozlowski
  2024-08-18 17:29 ` [PATCH net-next 2/4] dt-bindings: net: mediatek,net: add top-level constraints Krzysztof Kozlowski
                   ` (4 more replies)
  0 siblings, 5 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2024-08-18 17:29 UTC (permalink / raw)
  To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, Sergey Shtylyov,
	Kunihiko Hayashi, Masami Hiramatsu, Matthias Brugger,
	AngeloGioacchino Del Regno, Geert Uytterhoeven, Magnus Damm,
	Lorenzo Bianconi, Felix Fietkau, Sergei Shtylyov, netdev,
	devicetree, linux-kernel, linux-renesas-soc, linux-arm-kernel,
	linux-mediatek
  Cc: Krzysztof Kozlowski

Each variable-length property like interrupts must have fixed
constraints on number of items for given variant in binding.  The
clauses in "if:then:" block should define both limits: upper and lower.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 Documentation/devicetree/bindings/net/mediatek,net.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/mediatek,net.yaml b/Documentation/devicetree/bindings/net/mediatek,net.yaml
index 686b5c2fae40..8c00a6f75357 100644
--- a/Documentation/devicetree/bindings/net/mediatek,net.yaml
+++ b/Documentation/devicetree/bindings/net/mediatek,net.yaml
@@ -127,6 +127,7 @@ allOf:
     then:
       properties:
         interrupts:
+          minItems: 3
           maxItems: 3
 
         clocks:
@@ -183,6 +184,7 @@ allOf:
     then:
       properties:
         interrupts:
+          minItems: 3
           maxItems: 3
 
         clocks:
@@ -222,6 +224,7 @@ allOf:
     then:
       properties:
         interrupts:
+          minItems: 3
           maxItems: 3
 
         clocks:
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH net-next 2/4] dt-bindings: net: mediatek,net: add top-level constraints
  2024-08-18 17:29 [PATCH net-next 1/4] dt-bindings: net: mediatek,net: narrow interrupts per variants Krzysztof Kozlowski
@ 2024-08-18 17:29 ` Krzysztof Kozlowski
  2024-08-19 17:15   ` Rob Herring (Arm)
  2024-08-18 17:29 ` [PATCH net-next 3/4] dt-bindings: net: renesas,etheravb: " Krzysztof Kozlowski
                   ` (3 subsequent siblings)
  4 siblings, 1 reply; 9+ messages in thread
From: Krzysztof Kozlowski @ 2024-08-18 17:29 UTC (permalink / raw)
  To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, Sergey Shtylyov,
	Kunihiko Hayashi, Masami Hiramatsu, Matthias Brugger,
	AngeloGioacchino Del Regno, Geert Uytterhoeven, Magnus Damm,
	Lorenzo Bianconi, Felix Fietkau, Sergei Shtylyov, netdev,
	devicetree, linux-kernel, linux-renesas-soc, linux-arm-kernel,
	linux-mediatek
  Cc: Krzysztof Kozlowski

Properties with variable number of items per each device are expected to
have widest constraints in top-level "properties:" block and further
customized (narrowed) in "if:then:".  Add missing top-level constraints
for clocks and clock-names.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 Documentation/devicetree/bindings/net/mediatek,net.yaml | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/mediatek,net.yaml b/Documentation/devicetree/bindings/net/mediatek,net.yaml
index 8c00a6f75357..9e02fd80af83 100644
--- a/Documentation/devicetree/bindings/net/mediatek,net.yaml
+++ b/Documentation/devicetree/bindings/net/mediatek,net.yaml
@@ -30,8 +30,13 @@ properties:
   reg:
     maxItems: 1
 
-  clocks: true
-  clock-names: true
+  clocks:
+    minItems: 2
+    maxItems: 24
+
+  clock-names:
+    minItems: 2
+    maxItems: 24
 
   interrupts:
     minItems: 1
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH net-next 3/4] dt-bindings: net: renesas,etheravb: add top-level constraints
  2024-08-18 17:29 [PATCH net-next 1/4] dt-bindings: net: mediatek,net: narrow interrupts per variants Krzysztof Kozlowski
  2024-08-18 17:29 ` [PATCH net-next 2/4] dt-bindings: net: mediatek,net: add top-level constraints Krzysztof Kozlowski
@ 2024-08-18 17:29 ` Krzysztof Kozlowski
  2024-08-19 17:15   ` Rob Herring (Arm)
  2024-08-18 17:29 ` [PATCH net-next 4/4] dt-bindings: net: socionext,uniphier-ave4: " Krzysztof Kozlowski
                   ` (2 subsequent siblings)
  4 siblings, 1 reply; 9+ messages in thread
From: Krzysztof Kozlowski @ 2024-08-18 17:29 UTC (permalink / raw)
  To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, Sergey Shtylyov,
	Kunihiko Hayashi, Masami Hiramatsu, Matthias Brugger,
	AngeloGioacchino Del Regno, Geert Uytterhoeven, Magnus Damm,
	Lorenzo Bianconi, Felix Fietkau, Sergei Shtylyov, netdev,
	devicetree, linux-kernel, linux-renesas-soc, linux-arm-kernel,
	linux-mediatek
  Cc: Krzysztof Kozlowski

Properties with variable number of items per each device are expected to
have widest constraints in top-level "properties:" block and further
customized (narrowed) in "if:then:".  Add missing top-level constraints
for reg, clocks, clock-names, interrupts and interrupt-names.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 .../bindings/net/renesas,etheravb.yaml        | 29 ++++++++++++-------
 1 file changed, 19 insertions(+), 10 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/renesas,etheravb.yaml b/Documentation/devicetree/bindings/net/renesas,etheravb.yaml
index 21a92f179093..1e00ef5b3acd 100644
--- a/Documentation/devicetree/bindings/net/renesas,etheravb.yaml
+++ b/Documentation/devicetree/bindings/net/renesas,etheravb.yaml
@@ -62,15 +62,27 @@ properties:
               - renesas,r9a08g045-gbeth # RZ/G3S
           - const: renesas,rzg2l-gbeth  # RZ/{G2L,G2UL,V2L} family
 
-  reg: true
+  reg:
+    minItems: 1
+    items:
+      - description: MAC register block
+      - description: Stream buffer
 
-  interrupts: true
+  interrupts:
+    minItems: 1
+    maxItems: 29
 
-  interrupt-names: true
+  interrupt-names:
+    minItems: 1
+    maxItems: 29
 
-  clocks: true
+  clocks:
+    minItems: 1
+    maxItems: 3
 
-  clock-names: true
+  clock-names:
+    minItems: 1
+    maxItems: 3
 
   iommus:
     maxItems: 1
@@ -150,14 +162,11 @@ allOf:
     then:
       properties:
         reg:
-          items:
-            - description: MAC register block
-            - description: Stream buffer
+          minItems: 2
     else:
       properties:
         reg:
-          items:
-            - description: MAC register block
+          maxItems: 1
 
   - if:
       properties:
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH net-next 4/4] dt-bindings: net: socionext,uniphier-ave4: add top-level constraints
  2024-08-18 17:29 [PATCH net-next 1/4] dt-bindings: net: mediatek,net: narrow interrupts per variants Krzysztof Kozlowski
  2024-08-18 17:29 ` [PATCH net-next 2/4] dt-bindings: net: mediatek,net: add top-level constraints Krzysztof Kozlowski
  2024-08-18 17:29 ` [PATCH net-next 3/4] dt-bindings: net: renesas,etheravb: " Krzysztof Kozlowski
@ 2024-08-18 17:29 ` Krzysztof Kozlowski
  2024-08-19 17:15   ` Rob Herring (Arm)
  2024-08-19 17:15 ` [PATCH net-next 1/4] dt-bindings: net: mediatek,net: narrow interrupts per variants Rob Herring (Arm)
  2024-08-20 22:40 ` patchwork-bot+netdevbpf
  4 siblings, 1 reply; 9+ messages in thread
From: Krzysztof Kozlowski @ 2024-08-18 17:29 UTC (permalink / raw)
  To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, Sergey Shtylyov,
	Kunihiko Hayashi, Masami Hiramatsu, Matthias Brugger,
	AngeloGioacchino Del Regno, Geert Uytterhoeven, Magnus Damm,
	Lorenzo Bianconi, Felix Fietkau, Sergei Shtylyov, netdev,
	devicetree, linux-kernel, linux-renesas-soc, linux-arm-kernel,
	linux-mediatek
  Cc: Krzysztof Kozlowski

Properties with variable number of items per each device are expected to
have widest constraints in top-level "properties:" block and further
customized (narrowed) in "if:then:".  Add missing top-level constraints
for clock-names and reset-names.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 .../devicetree/bindings/net/socionext,uniphier-ave4.yaml  | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/socionext,uniphier-ave4.yaml b/Documentation/devicetree/bindings/net/socionext,uniphier-ave4.yaml
index b0ebcef6801c..4eb63b303cff 100644
--- a/Documentation/devicetree/bindings/net/socionext,uniphier-ave4.yaml
+++ b/Documentation/devicetree/bindings/net/socionext,uniphier-ave4.yaml
@@ -41,13 +41,17 @@ properties:
     minItems: 1
     maxItems: 4
 
-  clock-names: true
+  clock-names:
+    minItems: 1
+    maxItems: 4
 
   resets:
     minItems: 1
     maxItems: 2
 
-  reset-names: true
+  reset-names:
+    minItems: 1
+    maxItems: 2
 
   socionext,syscon-phy-mode:
     $ref: /schemas/types.yaml#/definitions/phandle-array
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH net-next 1/4] dt-bindings: net: mediatek,net: narrow interrupts per variants
  2024-08-18 17:29 [PATCH net-next 1/4] dt-bindings: net: mediatek,net: narrow interrupts per variants Krzysztof Kozlowski
                   ` (2 preceding siblings ...)
  2024-08-18 17:29 ` [PATCH net-next 4/4] dt-bindings: net: socionext,uniphier-ave4: " Krzysztof Kozlowski
@ 2024-08-19 17:15 ` Rob Herring (Arm)
  2024-08-20 22:40 ` patchwork-bot+netdevbpf
  4 siblings, 0 replies; 9+ messages in thread
From: Rob Herring (Arm) @ 2024-08-19 17:15 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: linux-renesas-soc, Conor Dooley, Felix Fietkau, David S. Miller,
	AngeloGioacchino Del Regno, Magnus Damm, Krzysztof Kozlowski,
	Lorenzo Bianconi, Jakub Kicinski, Geert Uytterhoeven,
	Eric Dumazet, Sergei Shtylyov, Matthias Brugger, Kunihiko Hayashi,
	Paolo Abeni, devicetree, linux-kernel, netdev, Masami Hiramatsu,
	Sergey Shtylyov, linux-mediatek, linux-arm-kernel


On Sun, 18 Aug 2024 19:29:02 +0200, Krzysztof Kozlowski wrote:
> Each variable-length property like interrupts must have fixed
> constraints on number of items for given variant in binding.  The
> clauses in "if:then:" block should define both limits: upper and lower.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  Documentation/devicetree/bindings/net/mediatek,net.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH net-next 2/4] dt-bindings: net: mediatek,net: add top-level constraints
  2024-08-18 17:29 ` [PATCH net-next 2/4] dt-bindings: net: mediatek,net: add top-level constraints Krzysztof Kozlowski
@ 2024-08-19 17:15   ` Rob Herring (Arm)
  0 siblings, 0 replies; 9+ messages in thread
From: Rob Herring (Arm) @ 2024-08-19 17:15 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Matthias Brugger, linux-kernel, linux-arm-kernel, David S. Miller,
	Magnus Damm, netdev, Kunihiko Hayashi, Masami Hiramatsu,
	Eric Dumazet, Geert Uytterhoeven, Krzysztof Kozlowski,
	Felix Fietkau, devicetree, Lorenzo Bianconi, linux-renesas-soc,
	Conor Dooley, AngeloGioacchino Del Regno, Paolo Abeni,
	linux-mediatek, Jakub Kicinski, Sergei Shtylyov, Sergey Shtylyov


On Sun, 18 Aug 2024 19:29:03 +0200, Krzysztof Kozlowski wrote:
> Properties with variable number of items per each device are expected to
> have widest constraints in top-level "properties:" block and further
> customized (narrowed) in "if:then:".  Add missing top-level constraints
> for clocks and clock-names.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  Documentation/devicetree/bindings/net/mediatek,net.yaml | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH net-next 3/4] dt-bindings: net: renesas,etheravb: add top-level constraints
  2024-08-18 17:29 ` [PATCH net-next 3/4] dt-bindings: net: renesas,etheravb: " Krzysztof Kozlowski
@ 2024-08-19 17:15   ` Rob Herring (Arm)
  0 siblings, 0 replies; 9+ messages in thread
From: Rob Herring (Arm) @ 2024-08-19 17:15 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Sergei Shtylyov, Kunihiko Hayashi, Paolo Abeni, David S. Miller,
	linux-mediatek, devicetree, Eric Dumazet, Geert Uytterhoeven,
	Sergey Shtylyov, Felix Fietkau, Lorenzo Bianconi,
	AngeloGioacchino Del Regno, Conor Dooley, Masami Hiramatsu,
	Krzysztof Kozlowski, Matthias Brugger, Jakub Kicinski,
	linux-arm-kernel, Magnus Damm, netdev, linux-kernel,
	linux-renesas-soc


On Sun, 18 Aug 2024 19:29:04 +0200, Krzysztof Kozlowski wrote:
> Properties with variable number of items per each device are expected to
> have widest constraints in top-level "properties:" block and further
> customized (narrowed) in "if:then:".  Add missing top-level constraints
> for reg, clocks, clock-names, interrupts and interrupt-names.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  .../bindings/net/renesas,etheravb.yaml        | 29 ++++++++++++-------
>  1 file changed, 19 insertions(+), 10 deletions(-)
> 

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH net-next 4/4] dt-bindings: net: socionext,uniphier-ave4: add top-level constraints
  2024-08-18 17:29 ` [PATCH net-next 4/4] dt-bindings: net: socionext,uniphier-ave4: " Krzysztof Kozlowski
@ 2024-08-19 17:15   ` Rob Herring (Arm)
  0 siblings, 0 replies; 9+ messages in thread
From: Rob Herring (Arm) @ 2024-08-19 17:15 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Lorenzo Bianconi, Matthias Brugger, Felix Fietkau,
	AngeloGioacchino Del Regno, netdev, Masami Hiramatsu,
	Sergei Shtylyov, Kunihiko Hayashi, linux-arm-kernel, Magnus Damm,
	Sergey Shtylyov, Geert Uytterhoeven, Paolo Abeni, Conor Dooley,
	David S. Miller, Jakub Kicinski, linux-kernel, linux-renesas-soc,
	Eric Dumazet, Krzysztof Kozlowski, devicetree, linux-mediatek


On Sun, 18 Aug 2024 19:29:05 +0200, Krzysztof Kozlowski wrote:
> Properties with variable number of items per each device are expected to
> have widest constraints in top-level "properties:" block and further
> customized (narrowed) in "if:then:".  Add missing top-level constraints
> for clock-names and reset-names.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  .../devicetree/bindings/net/socionext,uniphier-ave4.yaml  | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH net-next 1/4] dt-bindings: net: mediatek,net: narrow interrupts per variants
  2024-08-18 17:29 [PATCH net-next 1/4] dt-bindings: net: mediatek,net: narrow interrupts per variants Krzysztof Kozlowski
                   ` (3 preceding siblings ...)
  2024-08-19 17:15 ` [PATCH net-next 1/4] dt-bindings: net: mediatek,net: narrow interrupts per variants Rob Herring (Arm)
@ 2024-08-20 22:40 ` patchwork-bot+netdevbpf
  4 siblings, 0 replies; 9+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-08-20 22:40 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: davem, edumazet, kuba, pabeni, robh, krzk+dt, conor+dt,
	s.shtylyov, hayashi.kunihiko, mhiramat, matthias.bgg,
	angelogioacchino.delregno, geert+renesas, magnus.damm, lorenzo,
	nbd, sergei.shtylyov, netdev, devicetree, linux-kernel,
	linux-renesas-soc, linux-arm-kernel, linux-mediatek

Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Sun, 18 Aug 2024 19:29:02 +0200 you wrote:
> Each variable-length property like interrupts must have fixed
> constraints on number of items for given variant in binding.  The
> clauses in "if:then:" block should define both limits: upper and lower.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  Documentation/devicetree/bindings/net/mediatek,net.yaml | 3 +++
>  1 file changed, 3 insertions(+)

Here is the summary with links:
  - [net-next,1/4] dt-bindings: net: mediatek,net: narrow interrupts per variants
    https://git.kernel.org/netdev/net-next/c/55da77dec1be
  - [net-next,2/4] dt-bindings: net: mediatek,net: add top-level constraints
    https://git.kernel.org/netdev/net-next/c/06ab21c3cb6e
  - [net-next,3/4] dt-bindings: net: renesas,etheravb: add top-level constraints
    https://git.kernel.org/netdev/net-next/c/70d16e13368c
  - [net-next,4/4] dt-bindings: net: socionext,uniphier-ave4: add top-level constraints
    https://git.kernel.org/netdev/net-next/c/2862c9349d5d

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2024-08-20 22:40 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-18 17:29 [PATCH net-next 1/4] dt-bindings: net: mediatek,net: narrow interrupts per variants Krzysztof Kozlowski
2024-08-18 17:29 ` [PATCH net-next 2/4] dt-bindings: net: mediatek,net: add top-level constraints Krzysztof Kozlowski
2024-08-19 17:15   ` Rob Herring (Arm)
2024-08-18 17:29 ` [PATCH net-next 3/4] dt-bindings: net: renesas,etheravb: " Krzysztof Kozlowski
2024-08-19 17:15   ` Rob Herring (Arm)
2024-08-18 17:29 ` [PATCH net-next 4/4] dt-bindings: net: socionext,uniphier-ave4: " Krzysztof Kozlowski
2024-08-19 17:15   ` Rob Herring (Arm)
2024-08-19 17:15 ` [PATCH net-next 1/4] dt-bindings: net: mediatek,net: narrow interrupts per variants Rob Herring (Arm)
2024-08-20 22:40 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).