From: Basharath Hussain Khaja <basharath@couthit.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: basharath <basharath@couthit.com>,
danishanwar <danishanwar@ti.com>, rogerq <rogerq@kernel.org>,
andrew+netdev <andrew+netdev@lunn.ch>,
davem <davem@davemloft.net>, edumazet <edumazet@google.com>,
kuba <kuba@kernel.org>, pabeni <pabeni@redhat.com>,
Rob Herring <robh@kernel.org>, krzk+dt <krzk+dt@kernel.org>,
conor+dt <conor+dt@kernel.org>, nm <nm@ti.com>,
ssantosh <ssantosh@kernel.org>, tony <tony@atomide.com>,
richardcochran <richardcochran@gmail.com>,
parvathi <parvathi@couthit.com>,
schnelle <schnelle@linux.ibm.com>,
rdunlap <rdunlap@infradead.org>,
diogo ivo <diogo.ivo@siemens.com>,
m-karicheri2 <m-karicheri2@ti.com>, horms <horms@kernel.org>,
jacob e keller <jacob.e.keller@intel.com>,
m-malladi <m-malladi@ti.com>,
javier carrasco cruz <javier.carrasco.cruz@gmail.com>,
afd <afd@ti.com>, s-anna <s-anna@ti.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
netdev <netdev@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-omap <linux-omap@vger.kernel.org>,
pratheesh <pratheesh@ti.com>, prajith <prajith@ti.com>,
vigneshr <vigneshr@ti.com>, praneeth <praneeth@ti.com>,
srk <srk@ti.com>, rogerq <rogerq@ti.com>,
krishna <krishna@couthit.com>, pmohan <pmohan@couthit.com>,
mohan <mohan@couthit.com>
Subject: Re: [RFC PATCH 01/10] dt-bindings: net: ti: Adds device tree binding for DUAL-EMAC mode support on PRU-ICSS2 for AM57xx SOCs
Date: Wed, 22 Jan 2025 20:33:50 +0530 (IST) [thread overview]
Message-ID: <1724623586.384707.1737558230381.JavaMail.zimbra@couthit.local> (raw)
In-Reply-To: <ef90ecc9-7bb1-4f18-bd14-c5a82f07021b@lunn.ch>
> On Wed, Jan 22, 2025 at 06:56:14PM +0530, Basharath Hussain Khaja wrote:
>>
>> >> + ti,no-half-duplex:
>> >> + type: boolean
>> >> + description:
>> >> + Disable half duplex operation on ICSSM MII port.
>> >
>> > I already asked this in the next patch, but why have this property? Is
>> > it because the hardware is broken? Or is this some sort of policy?
>> > Policy should not be in DT, DT describes the hardware, not the policy
>> > of how you use the hardware.
>> >
>>
>> This series of patches enables support for full-duplex only. Support for
>> half-duplex will be added in subsequent revisions. We will clean it up in
>> the next version.
>
> So you don't need this property. All you need to do is remove the 1/2
> duplex link modes using phy_remove_link_mode() and user space will not
> get the option to enable them, not will auto-neg advertise them.
Sure. We will remove this property and make necessary changes at all places in the next version.
Thanks & Best Regards,
Basharath
next prev parent reply other threads:[~2025-01-22 15:04 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-09 10:55 [RFC PATCH 00/10] PRU-ICSSM Ethernet Driver Basharath Hussain Khaja
2025-01-09 10:55 ` [RFC PATCH 01/10] dt-bindings: net: ti: Adds device tree binding for DUAL-EMAC mode support on PRU-ICSS2 for AM57xx SOCs Basharath Hussain Khaja
2025-01-09 14:16 ` Andrew Lunn
2025-01-22 13:21 ` Basharath Hussain Khaja
2025-01-09 16:02 ` Andrew Lunn
2025-01-22 13:26 ` Basharath Hussain Khaja
2025-01-22 13:43 ` Andrew Lunn
2025-01-22 15:03 ` Basharath Hussain Khaja [this message]
2025-01-10 16:15 ` Rob Herring
2025-01-22 13:43 ` Basharath Hussain Khaja
2025-01-10 16:16 ` Rob Herring
2025-01-22 13:46 ` Basharath Hussain Khaja
2025-01-22 15:28 ` Basharath Hussain Khaja
2025-01-09 10:55 ` [RFC PATCH 02/10] net: ti: prueth: Adds ICSSM Ethernet driver Basharath Hussain Khaja
2025-01-09 15:59 ` Andrew Lunn
2025-01-22 15:33 ` Basharath Hussain Khaja
2025-01-09 10:55 ` [RFC PATCH 03/10] net: ti: prueth: Adds PRUETH HW and SW configuration Basharath Hussain Khaja
2025-01-09 16:10 ` Andrew Lunn
2025-01-22 15:57 ` Basharath Hussain Khaja
2025-01-09 10:55 ` [RFC PATCH 04/10] net: ti: prueth: Adds link detection, RX and TX support Basharath Hussain Khaja
2025-01-09 16:24 ` Andrew Lunn
2025-01-23 7:02 ` Basharath Hussain Khaja
2025-01-23 7:16 ` Christophe JAILLET
2025-01-23 12:30 ` Basharath Hussain Khaja
2025-01-09 14:11 ` [RFC PATCH 00/10] PRU-ICSSM Ethernet Driver Andrew Lunn
2025-01-22 13:17 ` Basharath Hussain Khaja
2025-01-10 5:59 ` [RFC PATCH 05/10] net: ti: prueth: Adds ethtool support for ICSSM PRUETH Driver Basharath Hussain Khaja
2025-01-10 5:59 ` [RFC PATCH 06/10] net: ti: prueth: Adds HW timestamping support for PTP using PRU-ICSS IEP module Basharath Hussain Khaja
2025-01-11 16:35 ` Richard Cochran
2025-01-23 7:23 ` Basharath Hussain Khaja
2025-01-11 23:38 ` Jason Xing
2025-01-23 7:25 ` Basharath Hussain Khaja
2025-01-10 5:59 ` [RFC PATCH 07/10] net: ti: prueth: Adds support for network filters for traffic control supported by PRU-ICSS Basharath Hussain Khaja
2025-01-10 7:13 ` [RFC PATCH 08/10] net: ti: prueth: Adds support for RX interrupt coalescing/pacing Basharath Hussain Khaja
2025-01-10 7:13 ` [RFC PATCH 09/10] net: ti: prueth: Adds power management support for PRU-ICSS Basharath Hussain Khaja
2025-01-10 7:13 ` [RFC PATCH 10/10] arm: dts: ti: Adds device tree nodes for PRU Cores, IEP and eCAP modules of PRU-ICSS2 Instance Basharath Hussain Khaja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1724623586.384707.1737558230381.JavaMail.zimbra@couthit.local \
--to=basharath@couthit.com \
--cc=afd@ti.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=danishanwar@ti.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=diogo.ivo@siemens.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=javier.carrasco.cruz@gmail.com \
--cc=krishna@couthit.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=m-malladi@ti.com \
--cc=mohan@couthit.com \
--cc=netdev@vger.kernel.org \
--cc=nm@ti.com \
--cc=pabeni@redhat.com \
--cc=parvathi@couthit.com \
--cc=pmohan@couthit.com \
--cc=prajith@ti.com \
--cc=praneeth@ti.com \
--cc=pratheesh@ti.com \
--cc=rdunlap@infradead.org \
--cc=richardcochran@gmail.com \
--cc=robh@kernel.org \
--cc=rogerq@kernel.org \
--cc=rogerq@ti.com \
--cc=s-anna@ti.com \
--cc=schnelle@linux.ibm.com \
--cc=srk@ti.com \
--cc=ssantosh@kernel.org \
--cc=tony@atomide.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).