* [PATCH net-next v2] net: mdiobus: Debug print fwnode handle instead of raw pointer
@ 2024-09-06 6:22 Alexander Dahl
2024-09-10 10:30 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Alexander Dahl @ 2024-09-06 6:22 UTC (permalink / raw)
To: netdev
Cc: Calvin Johnson, Florian Fainelli, Andrew Lunn, Heiner Kallweit,
Russell King, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, open list
Was slightly misleading before, because printed is pointer to fwnode,
not to phy device, as placement in message suggested. Include header
for dev_dbg() declaration while at it.
Output before:
[ +0.001247] mdio_bus f802c000.ethernet-ffffffff: registered phy 2612f00a fwnode at address 3
Output after:
[ +0.001229] mdio_bus f802c000.ethernet-ffffffff: registered phy fwnode /ahb/apb/ethernet@f802c000/ethernet-phy@3 at address 3
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Alexander Dahl <ada@thorsis.com>
---
Notes:
v2:
- rebased on net-next
- collected Reviewed-by tags
v1:
- Link: https://lore.kernel.org/netdev/20240905143248.203153-1-ada@thorsis.com/T/#u
drivers/net/mdio/fwnode_mdio.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/mdio/fwnode_mdio.c b/drivers/net/mdio/fwnode_mdio.c
index fd02f5cbc853..b156493d7084 100644
--- a/drivers/net/mdio/fwnode_mdio.c
+++ b/drivers/net/mdio/fwnode_mdio.c
@@ -7,6 +7,7 @@
*/
#include <linux/acpi.h>
+#include <linux/dev_printk.h>
#include <linux/fwnode_mdio.h>
#include <linux/of.h>
#include <linux/phy.h>
@@ -104,7 +105,7 @@ int fwnode_mdiobus_phy_device_register(struct mii_bus *mdio,
return rc;
}
- dev_dbg(&mdio->dev, "registered phy %p fwnode at address %i\n",
+ dev_dbg(&mdio->dev, "registered phy fwnode %pfw at address %i\n",
child, addr);
return 0;
}
base-commit: 76930d3d20d595ffffe516df1b3d6a70c4f33bd6
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next v2] net: mdiobus: Debug print fwnode handle instead of raw pointer
2024-09-06 6:22 [PATCH net-next v2] net: mdiobus: Debug print fwnode handle instead of raw pointer Alexander Dahl
@ 2024-09-10 10:30 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-09-10 10:30 UTC (permalink / raw)
To: Alexander Dahl
Cc: netdev, calvin.johnson, florian.fainelli, andrew, hkallweit1,
linux, davem, edumazet, kuba, pabeni, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (main)
by Paolo Abeni <pabeni@redhat.com>:
On Fri, 6 Sep 2024 08:22:56 +0200 you wrote:
> Was slightly misleading before, because printed is pointer to fwnode,
> not to phy device, as placement in message suggested. Include header
> for dev_dbg() declaration while at it.
>
> Output before:
>
> [ +0.001247] mdio_bus f802c000.ethernet-ffffffff: registered phy 2612f00a fwnode at address 3
>
> [...]
Here is the summary with links:
- [net-next,v2] net: mdiobus: Debug print fwnode handle instead of raw pointer
https://git.kernel.org/netdev/net-next/c/525034e2e2ee
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-09-10 10:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-06 6:22 [PATCH net-next v2] net: mdiobus: Debug print fwnode handle instead of raw pointer Alexander Dahl
2024-09-10 10:30 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).