From: patchwork-bot+netdevbpf@kernel.org
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, andrew@lunn.ch,
hkallweit1@gmail.com, linux@armlinux.org.uk,
bartosz.golaszewski@linaro.org, ansuelsmth@gmail.com,
xiaoning.wang@nxp.com, jonathanh@nvidia.com, hfdevel@gmx.net
Subject: Re: [PATCH net] net: phy: aquantia: fix -ETIMEDOUT PHY probe failure when firmware not present
Date: Thu, 19 Sep 2024 11:00:28 +0000 [thread overview]
Message-ID: <172674362877.1509847.6220074723591714494.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20240913121230.2620122-1-vladimir.oltean@nxp.com>
Hello:
This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@redhat.com>:
On Fri, 13 Sep 2024 15:12:30 +0300 you wrote:
> The author of the blamed commit apparently did not notice something
> about aqr_wait_reset_complete(): it polls the exact same register -
> MDIO_MMD_VEND1:VEND1_GLOBAL_FW_ID - as aqr_firmware_load().
>
> Thus, the entire logic after the introduction of aqr_wait_reset_complete() is
> now completely side-stepped, because if aqr_wait_reset_complete()
> succeeds, MDIO_MMD_VEND1:VEND1_GLOBAL_FW_ID could have only been a
> non-zero value. The handling of the case where the register reads as 0
> is dead code, due to the previous -ETIMEDOUT having stopped execution
> and returning a fatal error to the caller. We never attempt to load
> new firmware if no firmware is present.
>
> [...]
Here is the summary with links:
- [net] net: phy: aquantia: fix -ETIMEDOUT PHY probe failure when firmware not present
https://git.kernel.org/netdev/net/c/194ef9d0de90
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2024-09-19 11:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-13 12:12 [PATCH net] net: phy: aquantia: fix -ETIMEDOUT PHY probe failure when firmware not present Vladimir Oltean
2024-09-13 13:18 ` Bartosz Golaszewski
2024-09-13 13:21 ` Vladimir Oltean
2024-09-14 13:16 ` Hans-Frieder Vogt
2024-09-19 11:00 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=172674362877.1509847.6220074723591714494.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hfdevel@gmx.net \
--cc=hkallweit1@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vladimir.oltean@nxp.com \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox