From: patchwork-bot+netdevbpf@kernel.org
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: netdev@vger.kernel.org, linux-net-drivers@amd.com,
bpf@vger.kernel.org, davem@davemloft.net, toke@redhat.com,
ast@kernel.org, daniel@iogearbox.net, ecree.xilinx@gmail.com,
edumazet@google.com, kuba@kernel.org, hawk@kernel.org,
john.fastabend@gmail.com, habetsm.xilinx@gmail.com,
pabeni@redhat.com, tglx@linutronix.de, mon@unformed.ru
Subject: Re: [PATCH net] sfc: Don't invoke xdp_do_flush() from netpoll.
Date: Thu, 03 Oct 2024 22:50:31 +0000 [thread overview]
Message-ID: <172799583176.2017964.8627494683961349191.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20241002125837.utOcRo6Y@linutronix.de>
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 2 Oct 2024 14:58:37 +0200 you wrote:
> Yury reported a crash in the sfc driver originated from
> netpoll_send_udp(). The netconsole sends a message and then netpoll
> invokes the driver's NAPI function with a budget of zero. It is
> dedicated to allow driver to free TX resources, that it may have used
> while sending the packet.
>
> In the netpoll case the driver invokes xdp_do_flush() unconditionally,
> leading to crash because bpf_net_context was never assigned.
>
> [...]
Here is the summary with links:
- [net] sfc: Don't invoke xdp_do_flush() from netpoll.
https://git.kernel.org/netdev/net/c/55e802468e1d
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2024-10-03 22:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-02 12:58 [PATCH net] sfc: Don't invoke xdp_do_flush() from netpoll Sebastian Andrzej Siewior
2024-10-02 13:36 ` Edward Cree
2024-10-03 22:44 ` Jakub Kicinski
2024-10-03 22:50 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=172799583176.2017964.8627494683961349191.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=ast@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=habetsm.xilinx@gmail.com \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-net-drivers@amd.com \
--cc=mon@unformed.ru \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tglx@linutronix.de \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).