* [PATCH net-next] Remove unused tw_cookie_values from tcp_timewait_sock
@ 2013-03-10 15:18 Christoph Paasch
2013-03-10 16:06 ` Eric Dumazet
0 siblings, 1 reply; 4+ messages in thread
From: Christoph Paasch @ 2013-03-10 15:18 UTC (permalink / raw)
To: David Miller; +Cc: netdev, william.allen.simpson
tw_cookie_values is never used in the TCP-stack.
It was added by 435cf559f (TCPCT part 1d: define TCP cookie option,
extend existing struct's), but already at that time it was not used at
all, nor mentioned in the commit-message.
Signed-off-by: Christoph Paasch <christoph.paasch@uclouvain.be>
---
include/linux/tcp.h | 4 ----
1 file changed, 4 deletions(-)
diff --git a/include/linux/tcp.h b/include/linux/tcp.h
index f28408c..515c374 100644
--- a/include/linux/tcp.h
+++ b/include/linux/tcp.h
@@ -361,10 +361,6 @@ struct tcp_timewait_sock {
#ifdef CONFIG_TCP_MD5SIG
struct tcp_md5sig_key *tw_md5_key;
#endif
- /* Few sockets in timewait have cookies; in that case, then this
- * object holds a reference to them (tw_cookie_values->kref).
- */
- struct tcp_cookie_values *tw_cookie_values;
};
static inline struct tcp_timewait_sock *tcp_twsk(const struct sock *sk)
--
1.8.1.227.g44fe835
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net-next] Remove unused tw_cookie_values from tcp_timewait_sock
2013-03-10 15:18 [PATCH net-next] Remove unused tw_cookie_values from tcp_timewait_sock Christoph Paasch
@ 2013-03-10 16:06 ` Eric Dumazet
2013-03-10 16:33 ` Christoph Paasch
2013-03-10 21:09 ` David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Eric Dumazet @ 2013-03-10 16:06 UTC (permalink / raw)
To: Christoph Paasch; +Cc: David Miller, netdev, william.allen.simpson
On Sun, 2013-03-10 at 16:18 +0100, Christoph Paasch wrote:
> tw_cookie_values is never used in the TCP-stack.
>
> It was added by 435cf559f (TCPCT part 1d: define TCP cookie option,
> extend existing struct's), but already at that time it was not used at
> all, nor mentioned in the commit-message.
>
> Signed-off-by: Christoph Paasch <christoph.paasch@uclouvain.be>
> ---
> include/linux/tcp.h | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/include/linux/tcp.h b/include/linux/tcp.h
> index f28408c..515c374 100644
> --- a/include/linux/tcp.h
> +++ b/include/linux/tcp.h
> @@ -361,10 +361,6 @@ struct tcp_timewait_sock {
> #ifdef CONFIG_TCP_MD5SIG
> struct tcp_md5sig_key *tw_md5_key;
> #endif
> - /* Few sockets in timewait have cookies; in that case, then this
> - * object holds a reference to them (tw_cookie_values->kref).
> - */
> - struct tcp_cookie_values *tw_cookie_values;
> };
>
> static inline struct tcp_timewait_sock *tcp_twsk(const struct sock *sk)
Acked-by: Eric Dumazet <edumazet@google.com>
Actually, I am not sure TCPCT is really used...
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net-next] Remove unused tw_cookie_values from tcp_timewait_sock
2013-03-10 16:06 ` Eric Dumazet
@ 2013-03-10 16:33 ` Christoph Paasch
2013-03-10 21:09 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: Christoph Paasch @ 2013-03-10 16:33 UTC (permalink / raw)
To: Eric Dumazet; +Cc: David Miller, netdev, william.allen.simpson
On Sunday 10 March 2013 17:06:10 Eric Dumazet wrote:
> Acked-by: Eric Dumazet <edumazet@google.com>
>
> Actually, I am not sure TCPCT is really used...
Yes, while looking through the code it seems to me that it is far from
respecting RFC 6013.
It uses 253 as option-number and has comments saying "not yet implemented"
(e.g., tcp_parse_options).
Should it be removed?
Christoph
--
IP Networking Lab --- http://inl.info.ucl.ac.be
MultiPath TCP in the Linux Kernel --- http://mptcp.info.ucl.ac.be
UCLouvain
--
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] Remove unused tw_cookie_values from tcp_timewait_sock
2013-03-10 16:06 ` Eric Dumazet
2013-03-10 16:33 ` Christoph Paasch
@ 2013-03-10 21:09 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2013-03-10 21:09 UTC (permalink / raw)
To: eric.dumazet; +Cc: christoph.paasch, netdev, william.allen.simpson
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Sun, 10 Mar 2013 17:06:10 +0100
> On Sun, 2013-03-10 at 16:18 +0100, Christoph Paasch wrote:
>> tw_cookie_values is never used in the TCP-stack.
>>
>> It was added by 435cf559f (TCPCT part 1d: define TCP cookie option,
>> extend existing struct's), but already at that time it was not used at
>> all, nor mentioned in the commit-message.
>>
>> Signed-off-by: Christoph Paasch <christoph.paasch@uclouvain.be>
...
> Acked-by: Eric Dumazet <edumazet@google.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-03-10 21:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-10 15:18 [PATCH net-next] Remove unused tw_cookie_values from tcp_timewait_sock Christoph Paasch
2013-03-10 16:06 ` Eric Dumazet
2013-03-10 16:33 ` Christoph Paasch
2013-03-10 21:09 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox