[PATCH net-next] net: gianfar: Use __be64 * to store pointers to big endian values

[PATCH net-next] net: gianfar: Use __be64 * to store pointers to big endian values

[Simon Horman]

Timestamp values are read using pointers to 64-bit big endian values.
But the type of these pointers is u64 *, host byte order.
Use __be64 * instead.

Flagged by Sparse:

.../gianfar.c:2212:60: warning: cast to restricted __be64
.../gianfar.c:2475:53: warning: cast to restricted __be64

Introduced by
commit cc772ab7cdca ("gianfar: Add hardware RX timestamping support").

Compile tested only.
No functional change intended.

Signed-off-by: Simon Horman <horms@kernel.org>
---
 drivers/net/ethernet/freescale/gianfar.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/freescale/gianfar.c b/drivers/net/ethernet/freescale/gianfar.c
index 092db6995824..435138f4699d 100644
--- a/drivers/net/ethernet/freescale/gianfar.c
+++ b/drivers/net/ethernet/freescale/gianfar.c
@@ -2207,8 +2207,9 @@ static void gfar_clean_tx_ring(struct gfar_priv_tx_q *tx_queue)
 
 		if (unlikely(do_tstamp)) {
 			struct skb_shared_hwtstamps shhwtstamps;
-			u64 *ns = (u64 *)(((uintptr_t)skb->data + 0x10) &
-					  ~0x7UL);
+			__be64 *ns;
+
+			ns = (__be64 *)(((uintptr_t)skb->data + 0x10) & ~0x7UL);
 
 			memset(&shhwtstamps, 0, sizeof(shhwtstamps));
 			shhwtstamps.hwtstamp = ns_to_ktime(be64_to_cpu(*ns));
@@ -2471,7 +2472,7 @@ static void gfar_process_frame(struct net_device *ndev, struct sk_buff *skb)
 	/* Get receive timestamp from the skb */
 	if (priv->hwts_rx_en) {
 		struct skb_shared_hwtstamps *shhwtstamps = skb_hwtstamps(skb);
-		u64 *ns = (u64 *) skb->data;
+		__be64 *ns = (__be64 *)skb->data;
 
 		memset(shhwtstamps, 0, sizeof(*shhwtstamps));
 		shhwtstamps->hwtstamp = ns_to_ktime(be64_to_cpu(*ns));

RE: [PATCH net-next] net: gianfar: Use __be64 * to store pointers to big endian values

[Claudiu Manoil]

> -----Original Message-----
> From: Simon Horman <horms@kernel.org>
> Sent: Friday, October 11, 2024 12:20 PM
> To: Claudiu Manoil <claudiu.manoil@nxp.com>
> Cc: David S. Miller <davem@davemloft.net>; Eric Dumazet
> <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni
> <pabeni@redhat.com>; netdev@vger.kernel.org
> Subject: [PATCH net-next] net: gianfar: Use __be64 * to store pointers to big
> endian values
> 
> Timestamp values are read using pointers to 64-bit big endian values.
> But the type of these pointers is u64 *, host byte order.
> Use __be64 * instead.
> 
> Flagged by Sparse:
> 
> .../gianfar.c:2212:60: warning: cast to restricted __be64
> .../gianfar.c:2475:53: warning: cast to restricted __be64
> 
> Introduced by
> commit cc772ab7cdca ("gianfar: Add hardware RX timestamping support").
> 
> Compile tested only.
> No functional change intended.
> 
> Signed-off-by: Simon Horman <horms@kernel.org>

Reviewed-by: Claudiu Manoil <claudiu.manoil@nxp.com>

Re: [PATCH net-next] net: gianfar: Use __be64 * to store pointers to big endian values

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Paolo Abeni <pabeni@redhat.com>:

On Fri, 11 Oct 2024 10:20:00 +0100 you wrote:
> Timestamp values are read using pointers to 64-bit big endian values.
> But the type of these pointers is u64 *, host byte order.
> Use __be64 * instead.
> 
> Flagged by Sparse:
> 
> .../gianfar.c:2212:60: warning: cast to restricted __be64
> .../gianfar.c:2475:53: warning: cast to restricted __be64
> 
> [...]

Here is the summary with links:
  - [net-next] net: gianfar: Use __be64 * to store pointers to big endian values
    https://git.kernel.org/netdev/net-next/c/de306f0051ae

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html