netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v1 RESEND] net: sfp: change quirks for Alcatel Lucent G-010S-P
@ 2024-10-11 17:39 Shengyu Qu
  2024-10-17  8:04 ` Paolo Abeni
  2024-10-21  8:50 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 4+ messages in thread
From: Shengyu Qu @ 2024-10-11 17:39 UTC (permalink / raw)
  To: linux, andrew, hkallweit1, davem, edumazet, kuba, pabeni, netdev,
	linux-kernel
  Cc: Shengyu Qu

Seems Alcatel Lucent G-010S-P also have the same problem that it uses
TX_FAULT pin for SOC uart. So apply sfp_fixup_ignore_tx_fault to it.

Signed-off-by: Shengyu Qu <wiagn233@outlook.com>
---
The previous patch email was corrupted by my email client, so I did a
resend.
---
 drivers/net/phy/sfp.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c
index a5684ef5884bd..dcec92625cf65 100644
--- a/drivers/net/phy/sfp.c
+++ b/drivers/net/phy/sfp.c
@@ -466,7 +466,8 @@ static void sfp_quirk_ubnt_uf_instant(const struct sfp_eeprom_id *id,
 static const struct sfp_quirk sfp_quirks[] = {
 	// Alcatel Lucent G-010S-P can operate at 2500base-X, but incorrectly
 	// report 2500MBd NRZ in their EEPROM
-	SFP_QUIRK_M("ALCATELLUCENT", "G010SP", sfp_quirk_2500basex),
+	SFP_QUIRK("ALCATELLUCENT", "G010SP", sfp_quirk_2500basex,
+		  sfp_fixup_ignore_tx_fault),
 
 	// Alcatel Lucent G-010S-A can operate at 2500base-X, but report 3.2GBd
 	// NRZ in their EEPROM
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v1 RESEND] net: sfp: change quirks for Alcatel Lucent G-010S-P
  2024-10-11 17:39 [PATCH v1 RESEND] net: sfp: change quirks for Alcatel Lucent G-010S-P Shengyu Qu
@ 2024-10-17  8:04 ` Paolo Abeni
  2024-10-17 15:44   ` Shengyu Qu
  2024-10-21  8:50 ` patchwork-bot+netdevbpf
  1 sibling, 1 reply; 4+ messages in thread
From: Paolo Abeni @ 2024-10-17  8:04 UTC (permalink / raw)
  To: Shengyu Qu, linux, andrew, hkallweit1, davem, edumazet, kuba,
	netdev, linux-kernel

On 10/11/24 19:39, Shengyu Qu wrote:
> Seems Alcatel Lucent G-010S-P also have the same problem that it uses
> TX_FAULT pin for SOC uart. So apply sfp_fixup_ignore_tx_fault to it.
> 
> Signed-off-by: Shengyu Qu <wiagn233@outlook.com>
It would be great if a 3rd party could actually test this.

Leaving the patch pending a little more for such goal.

Thanks,

Paolo


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v1 RESEND] net: sfp: change quirks for Alcatel Lucent G-010S-P
  2024-10-17  8:04 ` Paolo Abeni
@ 2024-10-17 15:44   ` Shengyu Qu
  0 siblings, 0 replies; 4+ messages in thread
From: Shengyu Qu @ 2024-10-17 15:44 UTC (permalink / raw)
  To: Paolo Abeni, linux, andrew, hkallweit1, davem, edumazet, kuba,
	netdev, linux-kernel
  Cc: wiagn233

Hello Paulo,

We already have some information that I think is enough for this:
https://hack-gpon.org/ont-nokia-g-010s-p/

Best regards,
Shengyu

在 2024/10/17 16:04, Paolo Abeni 写道:
> On 10/11/24 19:39, Shengyu Qu wrote:
>> Seems Alcatel Lucent G-010S-P also have the same problem that it uses
>> TX_FAULT pin for SOC uart. So apply sfp_fixup_ignore_tx_fault to it.
>>
>> Signed-off-by: Shengyu Qu <wiagn233@outlook.com>
> It would be great if a 3rd party could actually test this.
> 
> Leaving the patch pending a little more for such goal.
> 
> Thanks,
> 
> Paolo
> 


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v1 RESEND] net: sfp: change quirks for Alcatel Lucent G-010S-P
  2024-10-11 17:39 [PATCH v1 RESEND] net: sfp: change quirks for Alcatel Lucent G-010S-P Shengyu Qu
  2024-10-17  8:04 ` Paolo Abeni
@ 2024-10-21  8:50 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-10-21  8:50 UTC (permalink / raw)
  To: Shengyu Qu
  Cc: linux, andrew, hkallweit1, davem, edumazet, kuba, pabeni, netdev,
	linux-kernel

Hello:

This patch was applied to netdev/net-next.git (main)
by Paolo Abeni <pabeni@redhat.com>:

On Sat, 12 Oct 2024 01:39:17 +0800 you wrote:
> Seems Alcatel Lucent G-010S-P also have the same problem that it uses
> TX_FAULT pin for SOC uart. So apply sfp_fixup_ignore_tx_fault to it.
> 
> Signed-off-by: Shengyu Qu <wiagn233@outlook.com>
> ---
> The previous patch email was corrupted by my email client, so I did a
> resend.
> 
> [...]

Here is the summary with links:
  - [v1,RESEND] net: sfp: change quirks for Alcatel Lucent G-010S-P
    https://git.kernel.org/netdev/net-next/c/90cb5f1776ba

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-10-21  8:50 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-11 17:39 [PATCH v1 RESEND] net: sfp: change quirks for Alcatel Lucent G-010S-P Shengyu Qu
2024-10-17  8:04 ` Paolo Abeni
2024-10-17 15:44   ` Shengyu Qu
2024-10-21  8:50 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).