From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Nambiar, Amritha" Subject: Re: [PATCH net] i40e: flower: check if TC offload is enabled on a netdev Date: Tue, 23 Jan 2018 01:10:18 -0800 Message-ID: <173046db-9ec7-b1bf-5247-ed1ebe23e86f@intel.com> References: <20180123080840.768-1-jakub.kicinski@netronome.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, oss-drivers@netronome.com, jeffrey.t.kirsher@intel.com, jiri@resnulli.us, alexander.h.duyck@intel.com To: Jakub Kicinski , davem@davemloft.net Return-path: Received: from mga02.intel.com ([134.134.136.20]:63503 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751027AbeAWJKV (ORCPT ); Tue, 23 Jan 2018 04:10:21 -0500 In-Reply-To: <20180123080840.768-1-jakub.kicinski@netronome.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 1/23/2018 12:08 AM, Jakub Kicinski wrote: > Since TC block changes drivers are required to check if > the TC hw offload flag is set on the interface themselves. > > Fixes: 2f4b411a3d67 ("i40e: Enable cloud filters via tc-flower") > Fixes: 44ae12a768b7 ("net: sched: move the can_offload check from binding phase to rule insertion phase") > Signed-off-by: Jakub Kicinski > Reviewed-by: Simon Horman Acked-by: Amritha Nambiar > --- > drivers/net/ethernet/intel/i40e/i40e_main.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c > index 42dcaefc4c19..af792112a2d3 100644 > --- a/drivers/net/ethernet/intel/i40e/i40e_main.c > +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c > @@ -7505,6 +7505,8 @@ static int i40e_setup_tc_cls_flower(struct i40e_netdev_priv *np, > { > struct i40e_vsi *vsi = np->vsi; > > + if (!tc_can_offload(vsi->netdev)) > + return -EOPNOTSUPP; > if (cls_flower->common.chain_index) > return -EOPNOTSUPP; > >