[PATCH v2 net-next] ionic: remove the unused nb_work

[PATCH v2 net-next] ionic: remove the unused nb_work

[Shannon Nelson]

From: Brett Creeley <brett.creeley@amd.com>

Remove the empty and unused nb_work and associated
ionic_lif_notify_work() function.

v2: separated from previous net patch

Link: https://lore.kernel.org/netdev/20241210174828.69525-2-shannon.nelson@amd.com/
Signed-off-by: Brett Creeley <brett.creeley@amd.com>
Signed-off-by: Shannon Nelson <shannon.nelson@amd.com>
---
 drivers/net/ethernet/pensando/ionic/ionic.h     | 1 -
 drivers/net/ethernet/pensando/ionic/ionic_lif.c | 7 -------
 2 files changed, 8 deletions(-)

diff --git a/drivers/net/ethernet/pensando/ionic/ionic.h b/drivers/net/ethernet/pensando/ionic/ionic.h
index 0639bf56bd3a..04f00ea94230 100644
--- a/drivers/net/ethernet/pensando/ionic/ionic.h
+++ b/drivers/net/ethernet/pensando/ionic/ionic.h
@@ -57,7 +57,6 @@ struct ionic {
 	DECLARE_BITMAP(intrs, IONIC_INTR_CTRL_REGS_MAX);
 	cpumask_var_t *affinity_masks;
 	struct delayed_work doorbell_check_dwork;
-	struct work_struct nb_work;
 	struct notifier_block nb;
 	struct rw_semaphore vf_op_lock;	/* lock for VF operations */
 	struct ionic_vf *vfs;
diff --git a/drivers/net/ethernet/pensando/ionic/ionic_lif.c b/drivers/net/ethernet/pensando/ionic/ionic_lif.c
index 052c767a2c75..05fb46effe0d 100644
--- a/drivers/net/ethernet/pensando/ionic/ionic_lif.c
+++ b/drivers/net/ethernet/pensando/ionic/ionic_lif.c
@@ -3804,10 +3804,6 @@ int ionic_lif_init(struct ionic_lif *lif)
 	return err;
 }
 
-static void ionic_lif_notify_work(struct work_struct *ws)
-{
-}
-
 static void ionic_lif_set_netdev_info(struct ionic_lif *lif)
 {
 	struct ionic_admin_ctx ctx = {
@@ -3858,8 +3854,6 @@ int ionic_lif_register(struct ionic_lif *lif)
 
 	ionic_lif_register_phc(lif);
 
-	INIT_WORK(&lif->ionic->nb_work, ionic_lif_notify_work);
-
 	lif->ionic->nb.notifier_call = ionic_lif_notify;
 
 	err = register_netdevice_notifier(&lif->ionic->nb);
@@ -3885,7 +3879,6 @@ void ionic_lif_unregister(struct ionic_lif *lif)
 {
 	if (lif->ionic->nb.notifier_call) {
 		unregister_netdevice_notifier(&lif->ionic->nb);
-		cancel_work_sync(&lif->ionic->nb_work);
 		lif->ionic->nb.notifier_call = NULL;
 	}
 
-- 
2.17.1

Re: [PATCH v2 net-next] ionic: remove the unused nb_work

[Jacob Keller]

On 12/12/2024 1:20 PM, Shannon Nelson wrote:
> From: Brett Creeley <brett.creeley@amd.com>
> 
> Remove the empty and unused nb_work and associated
> ionic_lif_notify_work() function.
> 
> v2: separated from previous net patch
> 

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>

Re: [PATCH v2 net-next] ionic: remove the unused nb_work

[Kalesh Anakkur Purayil]

[-- Attachment #1: Type: text/plain, Size: 568 bytes --]

On Fri, Dec 13, 2024 at 2:51 AM Shannon Nelson <shannon.nelson@amd.com> wrote:
>
> From: Brett Creeley <brett.creeley@amd.com>
>
> Remove the empty and unused nb_work and associated
> ionic_lif_notify_work() function.
>
> v2: separated from previous net patch
>
> Link: https://lore.kernel.org/netdev/20241210174828.69525-2-shannon.nelson@amd.com/
> Signed-off-by: Brett Creeley <brett.creeley@amd.com>
> Signed-off-by: Shannon Nelson <shannon.nelson@amd.com>

Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>


-- 
Regards,
Kalesh AP

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4239 bytes --]

Re: [PATCH v2 net-next] ionic: remove the unused nb_work

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Thu, 12 Dec 2024 13:20:42 -0800 you wrote:
> From: Brett Creeley <brett.creeley@amd.com>
> 
> Remove the empty and unused nb_work and associated
> ionic_lif_notify_work() function.
> 
> v2: separated from previous net patch
> 
> [...]

Here is the summary with links:
  - [v2,net-next] ionic: remove the unused nb_work
    https://git.kernel.org/netdev/net-next/c/a63bb6953966

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html