From: patchwork-bot+netdevbpf@kernel.org
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: aviad.krawczyk@huawei.com, cai.huoqing@linux.dev,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, zhaochen6@huawei.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net] net: hinic: Fix cleanup in create_rxqs/txqs()
Date: Tue, 17 Dec 2024 02:30:30 +0000 [thread overview]
Message-ID: <173440263001.420431.12522081889821148366.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <0cc98faf-a0ed-4565-a55b-0fa2734bc205@stanley.mountain>
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Fri, 13 Dec 2024 17:28:11 +0300 you wrote:
> There is a check for NULL at the start of create_txqs() and
> create_rxqs() which tess if "nic_dev->txqs" is non-NULL. The
> intention is that if the device is already open and the queues
> are already created then we don't create them a second time.
>
> However, the bug is that if we have an error in the create_txqs()
> then the pointer doesn't get set back to NULL. The NULL check
> at the start of the function will say that it's already open when
> it's not and the device can't be used.
>
> [...]
Here is the summary with links:
- [net] net: hinic: Fix cleanup in create_rxqs/txqs()
https://git.kernel.org/netdev/net/c/7203d10e93b6
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2024-12-17 2:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-13 14:28 [PATCH net] net: hinic: Fix cleanup in create_rxqs/txqs() Dan Carpenter
2024-12-16 10:33 ` Simon Horman
2024-12-17 2:30 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173440263001.420431.12522081889821148366.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=aviad.krawczyk@huawei.com \
--cc=cai.huoqing@linux.dev \
--cc=dan.carpenter@linaro.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=zhaochen6@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).