From: patchwork-bot+netdevbpf@kernel.org
To: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
Cc: m.chetan.kumar@intel.com, loic.poulain@linaro.org,
ryazanov.s.a@gmail.com, johannes@sipsolutions.net,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] net: wwan: iosm: Properly check for valid exec stage in ipc_mmio_init()
Date: Fri, 03 Jan 2025 02:50:40 +0000 [thread overview]
Message-ID: <173587264000.2091902.2245452495445092796.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <8b19125a825f9dcdd81c667c1e5c48ba28d505a6.1735490770.git.mail@maciej.szmigiero.name>
Hello:
This series was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Sun, 29 Dec 2024 17:46:58 +0100 you wrote:
> ipc_mmio_init() used the post-decrement operator in its loop continuing
> condition of "retries" counter being "> 0", which meant that when this
> condition caused loop exit "retries" counter reached -1.
>
> But the later valid exec stage failure check only tests for "retries"
> counter being exactly zero, so it didn't trigger in this case (but
> would wrongly trigger if the code reaches a valid exec stage in the
> very last loop iteration).
>
> [...]
Here is the summary with links:
- [1/2] net: wwan: iosm: Properly check for valid exec stage in ipc_mmio_init()
https://git.kernel.org/netdev/net/c/a7af435df0e0
- [2/2] net: wwan: iosm: Fix hibernation by re-binding the driver around it
(no matching commit)
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2025-01-03 2:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-29 16:46 [PATCH 1/2] net: wwan: iosm: Properly check for valid exec stage in ipc_mmio_init() Maciej S. Szmigiero
2024-12-29 16:46 ` [PATCH 2/2] net: wwan: iosm: Fix hibernation by re-binding the driver around it Maciej S. Szmigiero
2025-01-04 16:48 ` Jakub Kicinski
2025-01-03 2:50 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173587264000.2091902.2245452495445092796.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=m.chetan.kumar@intel.com \
--cc=mail@maciej.szmigiero.name \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ryazanov.s.a@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).