From: patchwork-bot+netdevbpf@kernel.org
To: Gal Pressman <gal@nvidia.com>
Cc: davem@davemloft.net, kuba@kernel.org, horms@kernel.org,
ecree.xilinx@gmail.com, netdev@vger.kernel.org,
edumazet@google.com, pabeni@redhat.com, ahmed.zaki@intel.com,
tariqt@nvidia.com
Subject: Re: [PATCH net] ethtool: Fix set RXNFC command with symmetric RSS hash
Date: Tue, 28 Jan 2025 11:40:32 +0000 [thread overview]
Message-ID: <173806443227.3766242.421041889613188874.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20250126191845.316589-1-gal@nvidia.com>
Hello:
This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@redhat.com>:
On Sun, 26 Jan 2025 21:18:45 +0200 you wrote:
> The sanity check that both source and destination are set when symmetric
> RSS hash is requested is only relevant for ETHTOOL_SRXFH (rx-flow-hash),
> it should not be performed on any other commands (e.g.
> ETHTOOL_SRXCLSRLINS/ETHTOOL_SRXCLSRLDEL).
>
> This resolves accessing uninitialized 'info.data' field, and fixes false
> errors in rule insertion:
> # ethtool --config-ntuple eth2 flow-type ip4 dst-ip 255.255.255.255 action -1 loc 0
> rmgr: Cannot insert RX class rule: Invalid argument
> Cannot insert classification rule
>
> [...]
Here is the summary with links:
- [net] ethtool: Fix set RXNFC command with symmetric RSS hash
https://git.kernel.org/netdev/net/c/4f5a52adeb1a
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2025-01-28 11:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-26 19:18 [PATCH net] ethtool: Fix set RXNFC command with symmetric RSS hash Gal Pressman
2025-01-27 6:18 ` Michal Swiatkowski
2025-01-27 14:14 ` Edward Cree
2025-01-27 15:01 ` Ahmed Zaki
2025-01-28 11:40 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173806443227.3766242.421041889613188874.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=ahmed.zaki@intel.com \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).