From: longli@linuxonhyperv.com
To: Jason Gunthorpe <jgg@ziepe.ca>, Leon Romanovsky <leon@kernel.org>,
Ajay Sharma <sharmaajay@microsoft.com>,
Konstantin Taranov <kotaranov@microsoft.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: linux-rdma@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org,
Long Li <longli@microsoft.com>
Subject: [Patch v2 0/3] IB/core: Fix GID cache for bonded net devices
Date: Fri, 7 Feb 2025 13:36:15 -0800 [thread overview]
Message-ID: <1738964178-18836-1-git-send-email-longli@linuxonhyperv.com> (raw)
From: Long Li <longli@microsoft.com>
When populating GID cache for net devices in a bonded setup, it should use the master device's
address whenever applicable.
The current code has some incorrect behaviors when dealing with bonded devices:
1. It adds IP of bonded slave to the GID cache when the device is already bonded
2. It adds IP of bonded slave to the GID cache when the device becomes bonded (via NETDEV_CHANGEUPPER notifier)
3. When a bonded slave device is unbonded, it doesn't add its IP to the default table in GID cache.
The patchset fixes those issues.
Changes log:
v2: Added cover letter explaining the overall problem and current behaviors.
Long Li (3):
IB/core: Do not use netdev IP if it is a bonded slave
IB/core: Use upper_device_filter to add upper ips
IB/core: Add default IP when a slave is unlinked
drivers/infiniband/core/roce_gid_mgmt.c | 17 +++++++++--------
1 file changed, 9 insertions(+), 8 deletions(-)
--
2.34.1
next reply other threads:[~2025-02-07 21:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-07 21:36 longli [this message]
2025-02-07 21:36 ` [Patch v2 1/3] IB/core: Do not use netdev IP if it is a bonded slave longli
2025-02-07 21:36 ` [Patch v2 2/3] IB/core: Use upper_device_filter to add upper ips longli
2025-02-07 21:36 ` [Patch v2 3/3] IB/core: Add default IP when a slave is unlinked longli
2025-02-09 9:45 ` [Patch v2 0/3] IB/core: Fix GID cache for bonded net devices Leon Romanovsky
2025-02-13 2:20 ` [EXTERNAL] " Long Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1738964178-18836-1-git-send-email-longli@linuxonhyperv.com \
--to=longli@linuxonhyperv.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jgg@ziepe.ca \
--cc=kotaranov@microsoft.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sharmaajay@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).