From: patchwork-bot+netdevbpf@kernel.org
To: Torben Nielsen <t8927095@gmail.com>
Cc: netdev@vger.kernel.org, torben.nielsen@prevas.dk
Subject: Re: [PATCH iproute2-next] tc: nat: Fix mask calculation
Date: Wed, 12 Mar 2025 18:30:32 +0000 [thread overview]
Message-ID: <174180423251.890466.11023139141419811729.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20250306112520.188728-1-torben.nielsen@prevas.dk>
Hello:
This patch was applied to iproute2/iproute2.git (main)
by Stephen Hemminger <stephen@networkplumber.org>:
On Thu, 6 Mar 2025 12:25:19 +0100 you wrote:
> In parse_nat_args the network mask is calculated as
>
> sel->mask = htonl(~0u << (32 - addr.bitlen));
>
> According to ISO/IEC 9899:TC3 6.5.7 Bitwise shift operators:
> The integer promotions are performed on each of the operands.
> The type of the result is that of the promoted left operand.
> If the value of the right operand is negative or is greater
> than or equal to the width of the promoted left operand,
> the behavior is undefined
>
> [...]
Here is the summary with links:
- [iproute2-next] tc: nat: Fix mask calculation
https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=667817b4c349
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2025-03-12 18:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-06 11:25 [PATCH iproute2-next] tc: nat: Fix mask calculation Torben Nielsen
2025-03-06 11:25 ` [PATCH iproute2-next] tc: nat: ffs should operation on host byte ordered data Torben Nielsen
2025-03-12 18:30 ` patchwork-bot+netdevbpf
2025-03-12 18:30 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174180423251.890466.11023139141419811729.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=t8927095@gmail.com \
--cc=torben.nielsen@prevas.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).