* [PATCH net-next] selftests: drv-net: rss_ctx: Don't assume indirection table is present
@ 2025-03-18 11:24 Gal Pressman
2025-03-20 20:03 ` Simon Horman
2025-03-24 19:30 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Gal Pressman @ 2025-03-18 11:24 UTC (permalink / raw)
To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Andrew Lunn, netdev
Cc: Shuah Khan, linux-kselftest, Gal Pressman, Nimrod Oren
The test_rss_context_dump() test assumes the indirection table is always
supported, which is not true for all drivers, e.g., virtio_net when
VIRTIO_NET_F_RSS is disabled.
Skip the check if 'indir' is not present.
Reviewed-by: Nimrod Oren <noren@nvidia.com>
Signed-off-by: Gal Pressman <gal@nvidia.com>
---
| 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--git a/tools/testing/selftests/drivers/net/hw/rss_ctx.py b/tools/testing/selftests/drivers/net/hw/rss_ctx.py
index d6e69d7d5e43..ca60ae325c22 100755
--- a/tools/testing/selftests/drivers/net/hw/rss_ctx.py
+++ b/tools/testing/selftests/drivers/net/hw/rss_ctx.py
@@ -392,7 +392,7 @@ def test_rss_context_dump(cfg):
# Sanity-check the results
for data in ctxs:
- ksft_ne(set(data['indir']), {0}, "indir table is all zero")
+ ksft_ne(set(data.get('indir', [1])), {0}, "indir table is all zero")
ksft_ne(set(data.get('hkey', [1])), {0}, "key is all zero")
# More specific checks
--
2.40.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] selftests: drv-net: rss_ctx: Don't assume indirection table is present
2025-03-18 11:24 [PATCH net-next] selftests: drv-net: rss_ctx: Don't assume indirection table is present Gal Pressman
@ 2025-03-20 20:03 ` Simon Horman
2025-03-24 19:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2025-03-20 20:03 UTC (permalink / raw)
To: Gal Pressman
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Andrew Lunn, netdev, Shuah Khan, linux-kselftest, Nimrod Oren
On Tue, Mar 18, 2025 at 01:24:26PM +0200, Gal Pressman wrote:
> The test_rss_context_dump() test assumes the indirection table is always
> supported, which is not true for all drivers, e.g., virtio_net when
> VIRTIO_NET_F_RSS is disabled.
>
> Skip the check if 'indir' is not present.
>
> Reviewed-by: Nimrod Oren <noren@nvidia.com>
> Signed-off-by: Gal Pressman <gal@nvidia.com>
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] selftests: drv-net: rss_ctx: Don't assume indirection table is present
2025-03-18 11:24 [PATCH net-next] selftests: drv-net: rss_ctx: Don't assume indirection table is present Gal Pressman
2025-03-20 20:03 ` Simon Horman
@ 2025-03-24 19:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-03-24 19:30 UTC (permalink / raw)
To: Gal Pressman
Cc: davem, edumazet, kuba, pabeni, andrew+netdev, netdev, shuah,
linux-kselftest, noren
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 18 Mar 2025 13:24:26 +0200 you wrote:
> The test_rss_context_dump() test assumes the indirection table is always
> supported, which is not true for all drivers, e.g., virtio_net when
> VIRTIO_NET_F_RSS is disabled.
>
> Skip the check if 'indir' is not present.
>
> Reviewed-by: Nimrod Oren <noren@nvidia.com>
> Signed-off-by: Gal Pressman <gal@nvidia.com>
>
> [...]
Here is the summary with links:
- [net-next] selftests: drv-net: rss_ctx: Don't assume indirection table is present
https://git.kernel.org/netdev/net-next/c/c61209eeb0b3
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-03-24 19:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-18 11:24 [PATCH net-next] selftests: drv-net: rss_ctx: Don't assume indirection table is present Gal Pressman
2025-03-20 20:03 ` Simon Horman
2025-03-24 19:30 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).