From: patchwork-bot+netdevbpf@kernel.org
To: Kuniyuki Iwashima <kuniyu@amazon.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, horms@kernel.org, sdf@fomichev.me,
kuni1840@gmail.com, netdev@vger.kernel.org,
syzbot+45016fe295243a7882d3@syzkaller.appspotmail.com
Subject: Re: [PATCH v1 net] rtnetlink: Fix bad unlock balance in do_setlink().
Date: Tue, 08 Apr 2025 19:51:40 +0000 [thread overview]
Message-ID: <174414190040.2109258.8169939556997104435.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20250407164229.24414-1-kuniyu@amazon.com>
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 7 Apr 2025 09:42:22 -0700 you wrote:
> When validate_linkmsg() fails in do_setlink(), we jump to the errout
> label and calls netdev_unlock_ops() even though we have not called
> netdev_lock_ops() as reported by syzbot. [0]
>
> Let's return an error directly in such a case.
>
> [0]
> WARNING: bad unlock balance detected!
> 6.14.0-syzkaller-12504-g8bc251e5d874 #0 Not tainted
>
> [...]
Here is the summary with links:
- [v1,net] rtnetlink: Fix bad unlock balance in do_setlink().
https://git.kernel.org/netdev/net/c/445e99bdf68d
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2025-04-08 19:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 16:42 [PATCH v1 net] rtnetlink: Fix bad unlock balance in do_setlink() Kuniyuki Iwashima
2025-04-07 16:57 ` Stanislav Fomichev
2025-04-08 19:51 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174414190040.2109258.8169939556997104435.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=kuni1840@gmail.com \
--cc=kuniyu@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=syzbot+45016fe295243a7882d3@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).