From: patchwork-bot+netdevbpf@kernel.org
To: Michael Chan <michael.chan@broadcom.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, andrew@lunn.ch,
horms@kernel.org, danieller@nvidia.com,
damodharam.ammepalli@broadcom.com,
andrew.gospodarek@broadcom.com, idosch@nvidia.com
Subject: Re: [PATCH net v2] ethtool: cmis_cdb: use correct rpl size in ethtool_cmis_module_poll()
Date: Sat, 12 Apr 2025 02:01:33 +0000 [thread overview]
Message-ID: <174442329375.549857.9802596514513043619.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20250409173312.733012-1-michael.chan@broadcom.com>
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 9 Apr 2025 10:33:12 -0700 you wrote:
> From: Damodharam Ammepalli <damodharam.ammepalli@broadcom.com>
>
> rpl is passed as a pointer to ethtool_cmis_module_poll(), so the correct
> size of rpl is sizeof(*rpl) which should be just 1 byte. Using the
> pointer size instead can cause stack corruption:
>
> Kernel panic - not syncing: stack-protector: Kernel stack is corrupted in: ethtool_cmis_wait_for_cond+0xf4/0x100
> CPU: 72 UID: 0 PID: 4440 Comm: kworker/72:2 Kdump: loaded Tainted: G OE 6.11.0 #24
> Tainted: [O]=OOT_MODULE, [E]=UNSIGNED_MODULE
> Hardware name: Dell Inc. PowerEdge R760/04GWWM, BIOS 1.6.6 09/20/2023
> Workqueue: events module_flash_fw_work
> Call Trace:
> <TASK>
> panic+0x339/0x360
> ? ethtool_cmis_wait_for_cond+0xf4/0x100
> ? __pfx_status_success+0x10/0x10
> ? __pfx_status_fail+0x10/0x10
> __stack_chk_fail+0x10/0x10
> ethtool_cmis_wait_for_cond+0xf4/0x100
> ethtool_cmis_cdb_execute_cmd+0x1fc/0x330
> ? __pfx_status_fail+0x10/0x10
> cmis_cdb_module_features_get+0x6d/0xd0
> ethtool_cmis_cdb_init+0x8a/0xd0
> ethtool_cmis_fw_update+0x46/0x1d0
> module_flash_fw_work+0x17/0xa0
> process_one_work+0x179/0x390
> worker_thread+0x239/0x340
> ? __pfx_worker_thread+0x10/0x10
> kthread+0xcc/0x100
> ? __pfx_kthread+0x10/0x10
> ret_from_fork+0x2d/0x50
> ? __pfx_kthread+0x10/0x10
> ret_from_fork_asm+0x1a/0x30
> </TASK>
>
> [...]
Here is the summary with links:
- [net,v2] ethtool: cmis_cdb: use correct rpl size in ethtool_cmis_module_poll()
https://git.kernel.org/netdev/net/c/f3fdd4fba16c
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2025-04-12 2:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-09 17:33 [PATCH net v2] ethtool: cmis_cdb: use correct rpl size in ethtool_cmis_module_poll() Michael Chan
2025-04-12 2:01 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174442329375.549857.9802596514513043619.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=andrew.gospodarek@broadcom.com \
--cc=andrew@lunn.ch \
--cc=damodharam.ammepalli@broadcom.com \
--cc=danieller@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).