public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Dan Jurgens <danielj@nvidia.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, mst@redhat.com, jasowang@redhat.com,
	pabeni@redhat.com, virtualization@lists.linux.dev,
	parav@nvidia.com, shshitrit@nvidia.com, yohadt@nvidia.com,
	xuanzhuo@linux.alibaba.com, eperezma@redhat.com, jgg@ziepe.ca,
	kevin.tian@intel.com, andrew+netdev@lunn.ch, edumazet@google.com
Subject: Re: [PATCH net-next v15 05/12] virtio_net: Query and set flow filter caps
Date: Wed, 7 Jan 2026 16:09:01 -0600	[thread overview]
Message-ID: <17453401-86b8-4fbc-8907-c2cf1faa06ac@nvidia.com> (raw)
In-Reply-To: <20260107133747.2ae75f3d@kernel.org>

On 1/7/26 3:37 PM, Jakub Kicinski wrote:
> On Wed, 7 Jan 2026 11:04:15 -0600 Daniel Jurgens wrote:
>> +	if (err && err != -EOPNOTSUPP) {
>> +		if (netif_running(vi->dev))
>> +			virtnet_close(vi->dev);
>> +
>> +		/* disable_rx_mmode_work takes the rtnl_lock, so just set the
>> +		 * flag here while holding the lock.
>> +		 *
>> +		 * remove_vq_common resets the device and frees the vqs.
>> +		 */
>> +		vi->rx_mode_work_enabled = false;
>> +		disable_delayed_refill(vi);
>> +		rtnl_unlock();
>> +		remove_vq_common(vi);
>> +		return err;
> 
> disable_delayed_refill() is going away in net 
> 
> https://lore.kernel.org/all/20260106150438.7425-1-minhquangbui99@gmail.com/
> 
> You'll have to wait for that change to propagate to net-next to avoid
> a transient build issue:
> 
> https://netdev.bots.linux.dev/contest.html?pw-n=0&branch=net-next-2026-01-07--21-00&pw-n=0&pass=0

Thanks for the heads up. The AI bot flagged another bug with the return
value of virtnet_restore_up so I'll send a v16 once this patch comes in.

  reply	other threads:[~2026-01-07 22:09 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-07 17:04 [PATCH net-next v15 00/12] virtio_net: Add ethtool flow rules support Daniel Jurgens
2026-01-07 17:04 ` [PATCH net-next v15 01/12] virtio_pci: Remove supported_cap size build assert Daniel Jurgens
2026-01-07 17:04 ` [PATCH net-next v15 02/12] virtio: Add config_op for admin commands Daniel Jurgens
2026-01-07 17:04 ` [PATCH net-next v15 03/12] virtio: Expose generic device capability operations Daniel Jurgens
2026-01-07 17:04 ` [PATCH net-next v15 04/12] virtio: Expose object create and destroy API Daniel Jurgens
2026-01-07 17:04 ` [PATCH net-next v15 05/12] virtio_net: Query and set flow filter caps Daniel Jurgens
2026-01-07 21:37   ` Jakub Kicinski
2026-01-07 22:09     ` Dan Jurgens [this message]
2026-01-07 23:33       ` Jakub Kicinski
2026-01-07 17:04 ` [PATCH net-next v15 06/12] virtio_net: Create a FF group for ethtool steering Daniel Jurgens
2026-01-07 17:04 ` [PATCH net-next v15 07/12] virtio_net: Implement layer 2 ethtool flow rules Daniel Jurgens
2026-01-07 17:04 ` [PATCH net-next v15 08/12] virtio_net: Use existing classifier if possible Daniel Jurgens
2026-01-07 17:04 ` [PATCH net-next v15 09/12] virtio_net: Implement IPv4 ethtool flow rules Daniel Jurgens
2026-01-07 17:04 ` [PATCH net-next v15 10/12] virtio_net: Add support for IPv6 ethtool steering Daniel Jurgens
2026-01-07 17:04 ` [PATCH net-next v15 11/12] virtio_net: Add support for TCP and UDP ethtool rules Daniel Jurgens
2026-01-07 17:04 ` [PATCH net-next v15 12/12] virtio_net: Add get ethtool flow rules ops Daniel Jurgens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17453401-86b8-4fbc-8907-c2cf1faa06ac@nvidia.com \
    --to=danielj@nvidia.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=edumazet@google.com \
    --cc=eperezma@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=jgg@ziepe.ca \
    --cc=kevin.tian@intel.com \
    --cc=kuba@kernel.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=parav@nvidia.com \
    --cc=shshitrit@nvidia.com \
    --cc=virtualization@lists.linux.dev \
    --cc=xuanzhuo@linux.alibaba.com \
    --cc=yohadt@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox