netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net v3] net: dp83822: Fix OF_MDIO config check
@ 2025-04-23  4:47 Johannes Schneider
  2025-04-23  9:54 ` Maxime Chevallier
  2025-04-24  9:50 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 3+ messages in thread
From: Johannes Schneider @ 2025-04-23  4:47 UTC (permalink / raw)
  To: dmurphy
  Cc: andrew, davem, f.fainelli, hkallweit1, kuba, linux-kernel, linux,
	michael, netdev, bsp-development.geo, Johannes Schneider

When CONFIG_OF_MDIO is set to be a module the code block is not
compiled. Use the IS_ENABLED macro that checks for both built in as
well as module.

Fixes: 5dc39fd5ef35 ("net: phy: DP83822: Add ability to advertise Fiber connection")
Signed-off-by: Johannes Schneider <johannes.schneider@leica-geosystems.com>
---
 drivers/net/phy/dp83822.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/phy/dp83822.c b/drivers/net/phy/dp83822.c
index 14f361549638..e32013eb0186 100644
--- a/drivers/net/phy/dp83822.c
+++ b/drivers/net/phy/dp83822.c
@@ -730,7 +730,7 @@ static int dp83822_phy_reset(struct phy_device *phydev)
 	return phydev->drv->config_init(phydev);
 }
 
-#ifdef CONFIG_OF_MDIO
+#if IS_ENABLED(CONFIG_OF_MDIO)
 static const u32 tx_amplitude_100base_tx_gain[] = {
 	80, 82, 83, 85, 87, 88, 90, 92,
 	93, 95, 97, 98, 100, 102, 103, 105,

base-commit: 9d7a0577c9db35c4cc52db90bc415ea248446472
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH net v3] net: dp83822: Fix OF_MDIO config check
  2025-04-23  4:47 [PATCH net v3] net: dp83822: Fix OF_MDIO config check Johannes Schneider
@ 2025-04-23  9:54 ` Maxime Chevallier
  2025-04-24  9:50 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: Maxime Chevallier @ 2025-04-23  9:54 UTC (permalink / raw)
  To: Johannes Schneider
  Cc: dmurphy, andrew, davem, f.fainelli, hkallweit1, kuba,
	linux-kernel, linux, michael, netdev, bsp-development.geo

On Wed, 23 Apr 2025 06:47:24 +0200
Johannes Schneider <johannes.schneider@leica-geosystems.com> wrote:

> When CONFIG_OF_MDIO is set to be a module the code block is not
> compiled. Use the IS_ENABLED macro that checks for both built in as
> well as module.
> 
> Fixes: 5dc39fd5ef35 ("net: phy: DP83822: Add ability to advertise Fiber connection")
> Signed-off-by: Johannes Schneider <johannes.schneider@leica-geosystems.com>

Reviewed-by: Maxime Chevallier <maxime.chevallier@bootlin.com>

Maxime

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net v3] net: dp83822: Fix OF_MDIO config check
  2025-04-23  4:47 [PATCH net v3] net: dp83822: Fix OF_MDIO config check Johannes Schneider
  2025-04-23  9:54 ` Maxime Chevallier
@ 2025-04-24  9:50 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-04-24  9:50 UTC (permalink / raw)
  To: Johannes Schneider
  Cc: dmurphy, andrew, davem, f.fainelli, hkallweit1, kuba,
	linux-kernel, linux, michael, netdev, bsp-development.geo

Hello:

This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@redhat.com>:

On Wed, 23 Apr 2025 06:47:24 +0200 you wrote:
> When CONFIG_OF_MDIO is set to be a module the code block is not
> compiled. Use the IS_ENABLED macro that checks for both built in as
> well as module.
> 
> Fixes: 5dc39fd5ef35 ("net: phy: DP83822: Add ability to advertise Fiber connection")
> Signed-off-by: Johannes Schneider <johannes.schneider@leica-geosystems.com>
> 
> [...]

Here is the summary with links:
  - [net,v3] net: dp83822: Fix OF_MDIO config check
    https://git.kernel.org/netdev/net/c/607b310ada5e

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-04-24  9:50 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-23  4:47 [PATCH net v3] net: dp83822: Fix OF_MDIO config check Johannes Schneider
2025-04-23  9:54 ` Maxime Chevallier
2025-04-24  9:50 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).