* [PATCH net v4] octeon_ep_vf: Resolve netdevice usage count issue
@ 2025-04-24 13:39 Sathesh B Edara
2025-04-26 2:00 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Sathesh B Edara @ 2025-04-24 13:39 UTC (permalink / raw)
To: netdev, linux-kernel
Cc: hgani, vimleshk, Veerasenareddy Burru, Sathesh Edara,
Shinas Rasheed, Satananda Burla, Andrew Lunn, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni
The netdevice usage count increases during transmit queue timeouts
because netdev_hold is called in ndo_tx_timeout, scheduling a task
to reinitialize the card. Although netdev_put is called at the end
of the scheduled work, rtnl_unlock checks the reference count during
cleanup. This could cause issues if transmit timeout is called on
multiple queues.
Fixes: cb7dd712189f ("octeon_ep_vf: Add driver framework and device initialization")
Signed-off-by: Sathesh B Edara <sedara@marvell.com>
---
Changes:
V4:
- use schedule_work() return value to put back netdevice usage count
V3:
- Added more description to commit message
V2:
- Removed redundant call
drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c b/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c
index 18c922dd5fc6..ccb69bc5c952 100644
--- a/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c
+++ b/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c
@@ -835,7 +835,9 @@ static void octep_vf_tx_timeout(struct net_device *netdev, unsigned int txqueue)
struct octep_vf_device *oct = netdev_priv(netdev);
netdev_hold(netdev, NULL, GFP_ATOMIC);
- schedule_work(&oct->tx_timeout_task);
+ if (!schedule_work(&oct->tx_timeout_task))
+ netdev_put(netdev, NULL);
+
}
static int octep_vf_set_mac(struct net_device *netdev, void *p)
--
2.36.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net v4] octeon_ep_vf: Resolve netdevice usage count issue
2025-04-24 13:39 [PATCH net v4] octeon_ep_vf: Resolve netdevice usage count issue Sathesh B Edara
@ 2025-04-26 2:00 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-04-26 2:00 UTC (permalink / raw)
To: Sathesh B Edara
Cc: netdev, linux-kernel, hgani, vimleshk, vburru, srasheed, sburla,
andrew+netdev, davem, edumazet, kuba, pabeni
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 24 Apr 2025 06:39:44 -0700 you wrote:
> The netdevice usage count increases during transmit queue timeouts
> because netdev_hold is called in ndo_tx_timeout, scheduling a task
> to reinitialize the card. Although netdev_put is called at the end
> of the scheduled work, rtnl_unlock checks the reference count during
> cleanup. This could cause issues if transmit timeout is called on
> multiple queues.
>
> [...]
Here is the summary with links:
- [net,v4] octeon_ep_vf: Resolve netdevice usage count issue
https://git.kernel.org/netdev/net/c/8548c84c004b
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-04-26 1:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-24 13:39 [PATCH net v4] octeon_ep_vf: Resolve netdevice usage count issue Sathesh B Edara
2025-04-26 2:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).