From: patchwork-bot+netdevbpf@kernel.org
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
jasowang@redhat.com, mst@redhat.com, xuanzhuo@linux.alibaba.com,
eperezma@redhat.com, hawk@kernel.org, john.fastabend@gmail.com,
virtualization@lists.linux.dev, minhquangbui99@gmail.com
Subject: Re: [PATCH net v2] virtio-net: free xsk_buffs on error in virtnet_xsk_pool_enable()
Date: Mon, 05 May 2025 23:51:22 +0000 [thread overview]
Message-ID: <174648908298.967302.6128357304548070079.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20250430163836.3029761-1-kuba@kernel.org>
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 30 Apr 2025 09:38:36 -0700 you wrote:
> The selftests added to our CI by Bui Quang Minh recently reveals
> that there is a mem leak on the error path of virtnet_xsk_pool_enable():
>
> unreferenced object 0xffff88800a68a000 (size 2048):
> comm "xdp_helper", pid 318, jiffies 4294692778
> hex dump (first 32 bytes):
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> backtrace (crc 0):
> __kvmalloc_node_noprof+0x402/0x570
> virtnet_xsk_pool_enable+0x293/0x6a0 (drivers/net/virtio_net.c:5882)
> xp_assign_dev+0x369/0x670 (net/xdp/xsk_buff_pool.c:226)
> xsk_bind+0x6a5/0x1ae0
> __sys_bind+0x15e/0x230
> __x64_sys_bind+0x72/0xb0
> do_syscall_64+0xc1/0x1d0
> entry_SYSCALL_64_after_hwframe+0x77/0x7f
>
> [...]
Here is the summary with links:
- [net,v2] virtio-net: free xsk_buffs on error in virtnet_xsk_pool_enable()
https://git.kernel.org/netdev/net/c/4397684a292a
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2025-05-05 23:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-30 16:38 [PATCH net v2] virtio-net: free xsk_buffs on error in virtnet_xsk_pool_enable() Jakub Kicinski
2025-05-05 23:51 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174648908298.967302.6128357304548070079.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eperezma@redhat.com \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=jasowang@redhat.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=minhquangbui99@gmail.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).