netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next] net: remove unused sock_enable_timestamps
@ 2025-06-09 15:32 Willem de Bruijn
  2025-06-10  0:18 ` Jason Xing
  2025-06-10 22:00 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 3+ messages in thread
From: Willem de Bruijn @ 2025-06-09 15:32 UTC (permalink / raw)
  To: netdev; +Cc: davem, kuba, edumazet, pabeni, horms, kernelxing,
	Willem de Bruijn

From: Willem de Bruijn <willemb@google.com>

This function was introduced in commit 783da70e8396 ("net: add
sock_enable_timestamps"), with one caller in rxrpc.

That only caller was removed in commit 7903d4438b3f ("rxrpc: Don't use
received skbuff timestamps").

Signed-off-by: Willem de Bruijn <willemb@google.com>
---
 include/net/sock.h | 1 -
 net/core/sock.c    | 8 --------
 2 files changed, 9 deletions(-)

diff --git a/include/net/sock.h b/include/net/sock.h
index 92e7c1aae3cc..85e17da5c9db 100644
--- a/include/net/sock.h
+++ b/include/net/sock.h
@@ -2982,7 +2982,6 @@ void sock_set_timestamp(struct sock *sk, int optname, bool valbool);
 int sock_set_timestamping(struct sock *sk, int optname,
 			  struct so_timestamping timestamping);
 
-void sock_enable_timestamps(struct sock *sk);
 #if defined(CONFIG_CGROUP_BPF)
 void bpf_skops_tx_timestamping(struct sock *sk, struct sk_buff *skb, int op);
 #else
diff --git a/net/core/sock.c b/net/core/sock.c
index 3b409bc8ef6d..502042a0d3b5 100644
--- a/net/core/sock.c
+++ b/net/core/sock.c
@@ -837,14 +837,6 @@ static void __sock_set_timestamps(struct sock *sk, bool val, bool new, bool ns)
 	}
 }
 
-void sock_enable_timestamps(struct sock *sk)
-{
-	lock_sock(sk);
-	__sock_set_timestamps(sk, true, false, true);
-	release_sock(sk);
-}
-EXPORT_SYMBOL(sock_enable_timestamps);
-
 void sock_set_timestamp(struct sock *sk, int optname, bool valbool)
 {
 	switch (optname) {
-- 
2.50.0.rc0.604.gd4ff7b7c86-goog


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] net: remove unused sock_enable_timestamps
  2025-06-09 15:32 [PATCH net-next] net: remove unused sock_enable_timestamps Willem de Bruijn
@ 2025-06-10  0:18 ` Jason Xing
  2025-06-10 22:00 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: Jason Xing @ 2025-06-10  0:18 UTC (permalink / raw)
  To: Willem de Bruijn
  Cc: netdev, davem, kuba, edumazet, pabeni, horms, kernelxing,
	Willem de Bruijn

On Mon, Jun 9, 2025 at 11:33 PM Willem de Bruijn
<willemdebruijn.kernel@gmail.com> wrote:
>
> From: Willem de Bruijn <willemb@google.com>
>
> This function was introduced in commit 783da70e8396 ("net: add
> sock_enable_timestamps"), with one caller in rxrpc.
>
> That only caller was removed in commit 7903d4438b3f ("rxrpc: Don't use
> received skbuff timestamps").
>
> Signed-off-by: Willem de Bruijn <willemb@google.com>

Reviewed-by: Jason Xing <kerneljasonxing@gmail.com>

Thanks,
Jason

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] net: remove unused sock_enable_timestamps
  2025-06-09 15:32 [PATCH net-next] net: remove unused sock_enable_timestamps Willem de Bruijn
  2025-06-10  0:18 ` Jason Xing
@ 2025-06-10 22:00 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-06-10 22:00 UTC (permalink / raw)
  To: Willem de Bruijn
  Cc: netdev, davem, kuba, edumazet, pabeni, horms, kernelxing, willemb

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Mon,  9 Jun 2025 11:32:35 -0400 you wrote:
> From: Willem de Bruijn <willemb@google.com>
> 
> This function was introduced in commit 783da70e8396 ("net: add
> sock_enable_timestamps"), with one caller in rxrpc.
> 
> That only caller was removed in commit 7903d4438b3f ("rxrpc: Don't use
> received skbuff timestamps").
> 
> [...]

Here is the summary with links:
  - [net-next] net: remove unused sock_enable_timestamps
    https://git.kernel.org/netdev/net-next/c/561939ed4493

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-06-10 22:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-09 15:32 [PATCH net-next] net: remove unused sock_enable_timestamps Willem de Bruijn
2025-06-10  0:18 ` Jason Xing
2025-06-10 22:00 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).