From: Vadim Fedorenko <vadim.fedorenko@linux.dev>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Rodolfo Giometti <giometti@enneenne.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] pps: make number of PPS devices configurable
Date: Thu, 14 May 2026 15:09:16 +0100 [thread overview]
Message-ID: <174e2370-959e-4b41-ab55-8058b84a12f6@linux.dev> (raw)
In-Reply-To: <20260514070804.7cbb6181@kernel.org>
On 14/05/2026 15:08, Jakub Kicinski wrote:
> On Thu, 14 May 2026 15:03:03 +0100 Vadim Fedorenko wrote:
>> On 14/05/2026 14:55, Jakub Kicinski wrote:
>>> On Thu, 14 May 2026 11:26:14 +0000 Vadim Fedorenko wrote:
>>>> Modern systems may have more than 16 PPS sources and current hard-coded
>>>> limit breaks registration of some devices. Make the limit configurable
>>>> via Kconfig, keep default value of 16 devices. UAPI has to be changed to
>>>> support maximum possible number.
>>>
>>> Hm, since this is effectively just sizing an IDR maybe we should just
>>> bump it to 64? It appears to cost nothing if not used.
>>
>> Just bump to 64, but keep it constant? In this case maybe 256 just to
>> align with the max minor value for chardev (in compat mode)?
>
> That's fine too (the value is the count right? It's not the max id?
> Cause 256 would spill out of u8)
It's the count. Max id will be 255.
next prev parent reply other threads:[~2026-05-14 14:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-14 11:26 [RFC PATCH] pps: make number of PPS devices configurable Vadim Fedorenko
2026-05-14 13:55 ` Jakub Kicinski
2026-05-14 14:03 ` Vadim Fedorenko
2026-05-14 14:08 ` Jakub Kicinski
2026-05-14 14:09 ` Vadim Fedorenko [this message]
2026-05-14 14:57 ` Rodolfo Giometti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174e2370-959e-4b41-ab55-8058b84a12f6@linux.dev \
--to=vadim.fedorenko@linux.dev \
--cc=giometti@enneenne.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox