[PATCH net-next] net: pse-pd: Fix ethnl_pse_send_ntf() stub parameter type

[PATCH net-next] net: pse-pd: Fix ethnl_pse_send_ntf() stub parameter type

[Kory Maincent]

The ethnl_pse_send_ntf() stub function has incorrect parameter type when
CONFIG_ETHTOOL_NETLINK is disabled. The function should take a net_device
pointer instead of phy_device pointer to match the actual implementation.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202506200355.TqFiYUbN-lkp@intel.com/
Fixes: fc0e6db30941 ("net: pse-pd: Add support for reporting events")
Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
---
 include/linux/ethtool_netlink.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/ethtool_netlink.h b/include/linux/ethtool_netlink.h
index 1dcc4059b5ab..39254b2726c0 100644
--- a/include/linux/ethtool_netlink.h
+++ b/include/linux/ethtool_netlink.h
@@ -122,7 +122,7 @@ static inline bool ethtool_dev_mm_supported(struct net_device *dev)
 	return false;
 }
 
-static inline void ethnl_pse_send_ntf(struct phy_device *phydev,
+static inline void ethnl_pse_send_ntf(struct net_device *netdev,
 				      unsigned long notif)
 {
 }
-- 
2.43.0

Re: [PATCH net-next] net: pse-pd: Fix ethnl_pse_send_ntf() stub parameter type

[Simon Horman]

On Fri, Jun 20, 2025 at 11:16:41AM +0200, Kory Maincent wrote:
> The ethnl_pse_send_ntf() stub function has incorrect parameter type when
> CONFIG_ETHTOOL_NETLINK is disabled. The function should take a net_device
> pointer instead of phy_device pointer to match the actual implementation.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202506200355.TqFiYUbN-lkp@intel.com/
> Fixes: fc0e6db30941 ("net: pse-pd: Add support for reporting events")
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>

I note that this is a fix for a patch present in net-next but not net,
so the Fixes tag + target of net-next combination looks good to me.

Reviewed-by: Simon Horman <horms@kernel.org>

Re: [PATCH net-next] net: pse-pd: Fix ethnl_pse_send_ntf() stub parameter type

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Fri, 20 Jun 2025 11:16:41 +0200 you wrote:
> The ethnl_pse_send_ntf() stub function has incorrect parameter type when
> CONFIG_ETHTOOL_NETLINK is disabled. The function should take a net_device
> pointer instead of phy_device pointer to match the actual implementation.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202506200355.TqFiYUbN-lkp@intel.com/
> Fixes: fc0e6db30941 ("net: pse-pd: Add support for reporting events")
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> 
> [...]

Here is the summary with links:
  - [net-next] net: pse-pd: Fix ethnl_pse_send_ntf() stub parameter type
    https://git.kernel.org/netdev/net-next/c/99aa0bbb082e

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html