netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH ethtool] ethtool: hibmcge: fix wrong register address in pretty print of ethtool -d command
@ 2025-06-16 13:18 Jijie Shao
  2025-06-23 19:10 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: Jijie Shao @ 2025-06-16 13:18 UTC (permalink / raw)
  To: mkubecek
  Cc: shenjian15, liuyonglong, chenhao418, netdev, linux-kernel,
	shaojijie

The addresses of mac_addr_h and mac_addr_l are wrong,
they need to be swapped.

Fixes: d89f6ee9c12a ("hibmcge: add support dump registers for hibmcge driver")
Signed-off-by: Jijie Shao <shaojijie@huawei.com>
---
 hibmcge.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hibmcge.c b/hibmcge.c
index 921efd2..ca81bc0 100644
--- a/hibmcge.c
+++ b/hibmcge.c
@@ -36,8 +36,8 @@ static const struct hbg_offset_name_map hbg_spec_maps[] = {
 	{0x0004, "event_req"},
 	{0x0008, "mac_id"},
 	{0x000c, "phy_addr"},
-	{0x0010, "mac_addr_h"},
-	{0x0014, "mac_addr_l"},
+	{0x0010, "mac_addr_l"},
+	{0x0014, "mac_addr_h"},
 	{0x0018, "uc_max_num"},
 	{0x0024, "mdio_freq"},
 	{0x0028, "max_mtu"},
-- 
2.33.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH ethtool] ethtool: hibmcge: fix wrong register address in pretty print of ethtool -d command
  2025-06-16 13:18 [PATCH ethtool] ethtool: hibmcge: fix wrong register address in pretty print of ethtool -d command Jijie Shao
@ 2025-06-23 19:10 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-06-23 19:10 UTC (permalink / raw)
  To: Jijie Shao
  Cc: mkubecek, shenjian15, liuyonglong, chenhao418, netdev,
	linux-kernel

Hello:

This patch was applied to ethtool/ethtool.git (master)
by Michal Kubecek <mkubecek@suse.cz>:

On Mon, 16 Jun 2025 21:18:40 +0800 you wrote:
> The addresses of mac_addr_h and mac_addr_l are wrong,
> they need to be swapped.
> 
> Fixes: d89f6ee9c12a ("hibmcge: add support dump registers for hibmcge driver")
> Signed-off-by: Jijie Shao <shaojijie@huawei.com>
> ---
>  hibmcge.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Here is the summary with links:
  - [ethtool] ethtool: hibmcge: fix wrong register address in pretty print of ethtool -d command
    https://git.kernel.org/pub/scm/network/ethtool/ethtool.git/commit/?id=196c3609ad9b

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-06-23 19:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-16 13:18 [PATCH ethtool] ethtool: hibmcge: fix wrong register address in pretty print of ethtool -d command Jijie Shao
2025-06-23 19:10 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).