[PATCH net] enic: fix incorrect MTU comparison in enic_change_mtu()

[PATCH net] enic: fix incorrect MTU comparison in enic_change_mtu()

[Alok Tiwari]

The comparison in enic_change_mtu() incorrectly used the current
netdev->mtu instead of the new new_mtu value when warning about
an MTU exceeding the port MTU. This could suppress valid warnings
or issue incorrect ones.

Fix the condition and log to properly reflect the new_mtu.

Fixes: ab123fe071c9 ("enic: handle mtu change for vf properly")
Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
---
 drivers/net/ethernet/cisco/enic/enic_main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/cisco/enic/enic_main.c b/drivers/net/ethernet/cisco/enic/enic_main.c
index 773f5ad972a24..6bc8dfdb3d4be 100644
--- a/drivers/net/ethernet/cisco/enic/enic_main.c
+++ b/drivers/net/ethernet/cisco/enic/enic_main.c
@@ -1864,10 +1864,10 @@ static int enic_change_mtu(struct net_device *netdev, int new_mtu)
 	if (enic_is_dynamic(enic) || enic_is_sriov_vf(enic))
 		return -EOPNOTSUPP;
 
-	if (netdev->mtu > enic->port_mtu)
+	if (new_mtu > enic->port_mtu)
 		netdev_warn(netdev,
 			    "interface MTU (%d) set higher than port MTU (%d)\n",
-			    netdev->mtu, enic->port_mtu);
+			    new_mtu, enic->port_mtu);
 
 	return _enic_change_mtu(netdev, new_mtu);
 }
-- 
2.46.0

Re: [PATCH net] enic: fix incorrect MTU comparison in enic_change_mtu()

[Simon Horman]

On Sat, Jun 28, 2025 at 07:56:05AM -0700, Alok Tiwari wrote:
> The comparison in enic_change_mtu() incorrectly used the current
> netdev->mtu instead of the new new_mtu value when warning about
> an MTU exceeding the port MTU. This could suppress valid warnings
> or issue incorrect ones.
> 
> Fix the condition and log to properly reflect the new_mtu.
> 
> Fixes: ab123fe071c9 ("enic: handle mtu change for vf properly")
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>

Reviewed-by: Simon Horman <horms@kernel.org>

Re: [PATCH net] enic: fix incorrect MTU comparison in enic_change_mtu()

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Sat, 28 Jun 2025 07:56:05 -0700 you wrote:
> The comparison in enic_change_mtu() incorrectly used the current
> netdev->mtu instead of the new new_mtu value when warning about
> an MTU exceeding the port MTU. This could suppress valid warnings
> or issue incorrect ones.
> 
> Fix the condition and log to properly reflect the new_mtu.
> 
> [...]

Here is the summary with links:
  - [net] enic: fix incorrect MTU comparison in enic_change_mtu()
    https://git.kernel.org/netdev/net/c/aaf2b2480375

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html