[PATCH v2 net-next] net: atlantic: Rename PCI driver struct to end in _driver

[PATCH v2 net-next] net: atlantic: Rename PCI driver struct to end in _driver

[Uwe Kleine-König]

This is not only a cosmetic change because the section mismatch checks
(implemented in scripts/mod/modpost.c) also depend on the object's name
and for drivers the checks are stricter than for ops.

However aq_pci_driver also passes the stricter checks just fine, so no
further changes needed.

The cheating^Wmisleading name was introduced in commit 97bde5c4f909
("net: ethernet: aquantia: Support for NIC-specific code")

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
---
Changes since implicit v1 (available at
https://lore.kernel.org/netdev/20250627094642.1923993-2-u.kleine-koenig@baylibre.com):

 - Improve commit log to explain in more detail the check
 - Mention the introducing commit in prose and not in a Fixes: line
 - trivially rebase to a newer next tag
 - explicitly mark for net-next in the Subject line

 drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c b/drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c
index 08630ee94251..ed5231dece3f 100644
--- a/drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c
+++ b/drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c
@@ -463,7 +463,7 @@ static const struct dev_pm_ops aq_pm_ops = {
 };
 #endif
 
-static struct pci_driver aq_pci_ops = {
+static struct pci_driver aq_pci_driver = {
 	.name = AQ_CFG_DRV_NAME,
 	.id_table = aq_pci_tbl,
 	.probe = aq_pci_probe,
@@ -476,11 +476,11 @@ static struct pci_driver aq_pci_ops = {
 
 int aq_pci_func_register_driver(void)
 {
-	return pci_register_driver(&aq_pci_ops);
+	return pci_register_driver(&aq_pci_driver);
 }
 
 void aq_pci_func_unregister_driver(void)
 {
-	pci_unregister_driver(&aq_pci_ops);
+	pci_unregister_driver(&aq_pci_driver);
 }
 
base-commit: 1343433ed38923a21425c602e92120a1f1db5f7a
-- 
2.49.0

Re: [PATCH v2 net-next] net: atlantic: Rename PCI driver struct to end in _driver

[Simon Horman]

On Mon, Jun 30, 2025 at 06:44:07PM +0200, Uwe Kleine-König wrote:
> This is not only a cosmetic change because the section mismatch checks
> (implemented in scripts/mod/modpost.c) also depend on the object's name
> and for drivers the checks are stricter than for ops.
> 
> However aq_pci_driver also passes the stricter checks just fine, so no
> further changes needed.
> 
> The cheating^Wmisleading name was introduced in commit 97bde5c4f909
> ("net: ethernet: aquantia: Support for NIC-specific code")
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
> ---
> Changes since implicit v1 (available at
> https://lore.kernel.org/netdev/20250627094642.1923993-2-u.kleine-koenig@baylibre.com):
> 
>  - Improve commit log to explain in more detail the check
>  - Mention the introducing commit in prose and not in a Fixes: line
>  - trivially rebase to a newer next tag
>  - explicitly mark for net-next in the Subject line

Thanks for your patience and making these updates.

Reviewed-by: Simon Horman <horms@kernel.org>

Re: [PATCH v2 net-next] net: atlantic: Rename PCI driver struct to end in _driver

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Mon, 30 Jun 2025 18:44:07 +0200 you wrote:
> This is not only a cosmetic change because the section mismatch checks
> (implemented in scripts/mod/modpost.c) also depend on the object's name
> and for drivers the checks are stricter than for ops.
> 
> However aq_pci_driver also passes the stricter checks just fine, so no
> further changes needed.
> 
> [...]

Here is the summary with links:
  - [v2,net-next] net: atlantic: Rename PCI driver struct to end in _driver
    https://git.kernel.org/netdev/net-next/c/b9ac2ae0008d

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html