[PATCH net] selftests: net: lib: fix shift count out of range

[PATCH net] selftests: net: lib: fix shift count out of range

[Hangbin Liu]

I got the following warning when writing other tests:

  + handle_test_result_pass 'bond 802.3ad' '(lacp_active off)'
  + local 'test_name=bond 802.3ad'
  + shift
  + local 'opt_str=(lacp_active off)'
  + shift
  + log_test_result 'bond 802.3ad' '(lacp_active off)' ' OK '
  + local 'test_name=bond 802.3ad'
  + shift
  + local 'opt_str=(lacp_active off)'
  + shift
  + local 'result= OK '
  + shift
  + local retmsg=
  + shift
  /net/tools/testing/selftests/net/forwarding/../lib.sh: line 315: shift: shift count out of range

This happens because an extra shift is executed even after all arguments
have been consumed. Remove the last shift in log_test_result() to avoid
this warning.

Fixes: a923af1ceee7 ("selftests: forwarding: Convert log_test() to recognize RET values")
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
---
 tools/testing/selftests/net/lib.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/net/lib.sh b/tools/testing/selftests/net/lib.sh
index 006fdadcc4b9..86a216e9aca8 100644
--- a/tools/testing/selftests/net/lib.sh
+++ b/tools/testing/selftests/net/lib.sh
@@ -312,7 +312,7 @@ log_test_result()
 	local test_name=$1; shift
 	local opt_str=$1; shift
 	local result=$1; shift
-	local retmsg=$1; shift
+	local retmsg=$1
 
 	printf "TEST: %-60s  [%s]\n" "$test_name $opt_str" "$result"
 	if [[ $retmsg ]]; then
-- 
2.46.0

Re: [PATCH net] selftests: net: lib: fix shift count out of range

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Wed,  9 Jul 2025 09:12:44 +0000 you wrote:
> I got the following warning when writing other tests:
> 
>   + handle_test_result_pass 'bond 802.3ad' '(lacp_active off)'
>   + local 'test_name=bond 802.3ad'
>   + shift
>   + local 'opt_str=(lacp_active off)'
>   + shift
>   + log_test_result 'bond 802.3ad' '(lacp_active off)' ' OK '
>   + local 'test_name=bond 802.3ad'
>   + shift
>   + local 'opt_str=(lacp_active off)'
>   + shift
>   + local 'result= OK '
>   + shift
>   + local retmsg=
>   + shift
>   /net/tools/testing/selftests/net/forwarding/../lib.sh: line 315: shift: shift count out of range
> 
> [...]

Here is the summary with links:
  - [net] selftests: net: lib: fix shift count out of range
    https://git.kernel.org/netdev/net/c/47c84997c686

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html