[GIT PULL] bluetooth 2025-07-17

[GIT PULL] bluetooth 2025-07-17

[Luiz Augusto von Dentz]

The following changes since commit dae7f9cbd1909de2b0bccc30afef95c23f93e477:

  Merge branch 'mptcp-fix-fallback-related-races' (2025-07-15 17:31:30 -0700)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth.git tags/for-net-2025-07-17

for you to fetch changes up to d24e4a7fedae121d33fb32ad785b87046527eedb:

  Bluetooth: L2CAP: Fix attempting to adjust outgoing MTU (2025-07-17 10:26:53 -0400)

----------------------------------------------------------------
bluetooth pull request for net:

 - hci_sync: fix connectable extended advertising when using static random address
 - hci_core: fix typos in macros
 - hci_core: add missing braces when using macro parameters
 - hci_core: replace 'quirks' integer by 'quirk_flags' bitmap
 - SMP: If an unallowed command is received consider it a failure
 - SMP: Fix using HCI_ERROR_REMOTE_USER_TERM on timeout
 - L2CAP: Fix null-ptr-deref in l2cap_sock_resume_cb()
 - L2CAP: Fix attempting to adjust outgoing MTU
 - btintel: Check if controller is ISO capable on btintel_classify_pkt_type
 - btusb: QCA: Fix downloading wrong NVM for WCN6855 GF variant without board ID

----------------------------------------------------------------
Alessandro Gasbarroni (1):
      Bluetooth: hci_sync: fix connectable extended advertising when using static random address

Christian Eggers (3):
      Bluetooth: hci_core: fix typos in macros
      Bluetooth: hci_core: add missing braces when using macro parameters
      Bluetooth: hci_dev: replace 'quirks' integer by 'quirk_flags' bitmap

Kuniyuki Iwashima (1):
      Bluetooth: Fix null-ptr-deref in l2cap_sock_resume_cb()

Luiz Augusto von Dentz (4):
      Bluetooth: btintel: Check if controller is ISO capable on btintel_classify_pkt_type
      Bluetooth: SMP: If an unallowed command is received consider it a failure
      Bluetooth: SMP: Fix using HCI_ERROR_REMOTE_USER_TERM on timeout
      Bluetooth: L2CAP: Fix attempting to adjust outgoing MTU

Zijun Hu (1):
      Bluetooth: btusb: QCA: Fix downloading wrong NVM for WCN6855 GF variant without board ID

 drivers/bluetooth/bfusb.c        |   2 +-
 drivers/bluetooth/bpa10x.c       |   2 +-
 drivers/bluetooth/btbcm.c        |   8 +--
 drivers/bluetooth/btintel.c      |  30 ++++----
 drivers/bluetooth/btintel_pcie.c |   8 +--
 drivers/bluetooth/btmtksdio.c    |   4 +-
 drivers/bluetooth/btmtkuart.c    |   2 +-
 drivers/bluetooth/btnxpuart.c    |   2 +-
 drivers/bluetooth/btqca.c        |   2 +-
 drivers/bluetooth/btqcomsmd.c    |   2 +-
 drivers/bluetooth/btrtl.c        |  10 +--
 drivers/bluetooth/btsdio.c       |   2 +-
 drivers/bluetooth/btusb.c        | 148 +++++++++++++++++++++------------------
 drivers/bluetooth/hci_aml.c      |   2 +-
 drivers/bluetooth/hci_bcm.c      |   4 +-
 drivers/bluetooth/hci_bcm4377.c  |  10 +--
 drivers/bluetooth/hci_intel.c    |   2 +-
 drivers/bluetooth/hci_ldisc.c    |   6 +-
 drivers/bluetooth/hci_ll.c       |   4 +-
 drivers/bluetooth/hci_nokia.c    |   2 +-
 drivers/bluetooth/hci_qca.c      |  14 ++--
 drivers/bluetooth/hci_serdev.c   |   8 +--
 drivers/bluetooth/hci_vhci.c     |   8 +--
 drivers/bluetooth/virtio_bt.c    |  10 +--
 include/net/bluetooth/hci.h      |   2 +
 include/net/bluetooth/hci_core.h |  50 +++++++------
 net/bluetooth/hci_core.c         |   4 +-
 net/bluetooth/hci_debugfs.c      |   8 +--
 net/bluetooth/hci_event.c        |  19 +++--
 net/bluetooth/hci_sync.c         |  63 ++++++++---------
 net/bluetooth/l2cap_core.c       |  26 +++++--
 net/bluetooth/l2cap_sock.c       |   3 +
 net/bluetooth/mgmt.c             |  38 +++++-----
 net/bluetooth/msft.c             |   2 +-
 net/bluetooth/smp.c              |  21 +++++-
 net/bluetooth/smp.h              |   1 +
 36 files changed, 289 insertions(+), 240 deletions(-)

Re: [GIT PULL] bluetooth 2025-07-17

[patchwork-bot+netdevbpf]

Hello:

This pull request was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Thu, 17 Jul 2025 10:28:49 -0400 you wrote:
> The following changes since commit dae7f9cbd1909de2b0bccc30afef95c23f93e477:
> 
>   Merge branch 'mptcp-fix-fallback-related-races' (2025-07-15 17:31:30 -0700)
> 
> are available in the Git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth.git tags/for-net-2025-07-17
> 
> [...]

Here is the summary with links:
  - [GIT,PULL] bluetooth 2025-07-17
    https://git.kernel.org/netdev/net/c/a2bbaff6816a

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Re: [GIT PULL] bluetooth 2025-07-17

[Jakub Kicinski]

On Thu, 17 Jul 2025 10:28:49 -0400 Luiz Augusto von Dentz wrote:
>       Bluetooth: hci_dev: replace 'quirks' integer by 'quirk_flags' bitmap

FTR this rename and adding the helpers does not seem to be very
necessary for the fix? I know Greg says that we shouldn't intentionally
try to make fixes small, but there's a fine line between following that
and coincidental code refactoring.

Re: [GIT PULL] bluetooth 2025-07-17

[Luiz Augusto von Dentz]

Hi Jakub,

On Thu, Jul 17, 2025 at 11:38 AM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Thu, 17 Jul 2025 10:28:49 -0400 Luiz Augusto von Dentz wrote:
> >       Bluetooth: hci_dev: replace 'quirks' integer by 'quirk_flags' bitmap
>
> FTR this rename and adding the helpers does not seem to be very
> necessary for the fix? I know Greg says that we shouldn't intentionally
> try to make fixes small, but there's a fine line between following that
> and coincidental code refactoring.

I should have reworded that commit, it is actually a fix, not just
renaming, we run out of bits on a 32 bits system due to usage of int
as storage.

-- 
Luiz Augusto von Dentz

Re: [GIT PULL] bluetooth 2025-07-17

[Jakub Kicinski]

On Thu, 17 Jul 2025 11:47:49 -0400 Luiz Augusto von Dentz wrote:
> > On Thu, 17 Jul 2025 10:28:49 -0400 Luiz Augusto von Dentz wrote:  
> > >       Bluetooth: hci_dev: replace 'quirks' integer by 'quirk_flags' bitmap  
> >
> > FTR this rename and adding the helpers does not seem to be very
> > necessary for the fix? I know Greg says that we shouldn't intentionally
> > try to make fixes small, but there's a fine line between following that
> > and coincidental code refactoring.  
> 
> I should have reworded that commit, it is actually a fix, not just
> renaming, we run out of bits on a 32 bits system due to usage of int
> as storage.

Right, but I think if the new bitmap was called quirks the existing
set_bit / test_bit call sites would have been just fine, right?
The bit ops operate on single ulong and bitmaps all the same.

Re: [GIT PULL] bluetooth 2025-07-17

[Luiz Augusto von Dentz]

Hi Jakub,

On Thu, Jul 17, 2025 at 11:54 AM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Thu, 17 Jul 2025 11:47:49 -0400 Luiz Augusto von Dentz wrote:
> > > On Thu, 17 Jul 2025 10:28:49 -0400 Luiz Augusto von Dentz wrote:
> > > >       Bluetooth: hci_dev: replace 'quirks' integer by 'quirk_flags' bitmap
> > >
> > > FTR this rename and adding the helpers does not seem to be very
> > > necessary for the fix? I know Greg says that we shouldn't intentionally
> > > try to make fixes small, but there's a fine line between following that
> > > and coincidental code refactoring.
> >
> > I should have reworded that commit, it is actually a fix, not just
> > renaming, we run out of bits on a 32 bits system due to usage of int
> > as storage.
>
> Right, but I think if the new bitmap was called quirks the existing
> set_bit / test_bit call sites would have been just fine, right?
> The bit ops operate on single ulong and bitmaps all the same.

I guess you are talking about the likes of hci_set_quirk vs using
set_bit directly? hci_set_quirk is just a macro that does use set_bit:

#define hci_set_quirk(hdev, nr) set_bit((nr), (hdev)->quirk_flags)

I guess we didn't have to introduce it at the same time and calling it
just quirks would be fine by me, but I find it cleaner this way even
though we had to fix all the drivers in the process, that said maybe
it won't be that easy to backport and may affect out of the tree
drivers just because we change its name.

-- 
Luiz Augusto von Dentz

Re: [GIT PULL] bluetooth 2025-07-17

[patchwork-bot+bluetooth]

Hello:

This pull request was applied to bluetooth/bluetooth-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Thu, 17 Jul 2025 10:28:49 -0400 you wrote:
> The following changes since commit dae7f9cbd1909de2b0bccc30afef95c23f93e477:
> 
>   Merge branch 'mptcp-fix-fallback-related-races' (2025-07-15 17:31:30 -0700)
> 
> are available in the Git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth.git tags/for-net-2025-07-17
> 
> [...]

Here is the summary with links:
  - [GIT,PULL] bluetooth 2025-07-17
    https://git.kernel.org/bluetooth/bluetooth-next/c/a2bbaff6816a

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html