netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/1] net: fsl_pq_mdio: use dev_err_probe
@ 2025-07-25  5:56 Alexander Stein
  2025-07-26 17:34 ` Simon Horman
  2025-07-26 18:40 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 3+ messages in thread
From: Alexander Stein @ 2025-07-25  5:56 UTC (permalink / raw)
  To: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni
  Cc: Alexander Stein, netdev, linux-kernel

Silence deferred probes using dev_err_probe(). This can happen when
the ethernet PHY uses an IRQ line attached to a i2c GPIO expander. If the
i2c bus is not yet ready, a probe deferral can occur.

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 drivers/net/ethernet/freescale/fsl_pq_mdio.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/freescale/fsl_pq_mdio.c b/drivers/net/ethernet/freescale/fsl_pq_mdio.c
index 56d2f79fb7e32..577f9b1780ad6 100644
--- a/drivers/net/ethernet/freescale/fsl_pq_mdio.c
+++ b/drivers/net/ethernet/freescale/fsl_pq_mdio.c
@@ -491,8 +491,8 @@ static int fsl_pq_mdio_probe(struct platform_device *pdev)
 
 	err = of_mdiobus_register(new_bus, np);
 	if (err) {
-		dev_err(&pdev->dev, "cannot register %s as MDIO bus\n",
-			new_bus->name);
+		dev_err_probe(&pdev->dev, err, "cannot register %s as MDIO bus\n",
+			      new_bus->name);
 		goto error;
 	}
 
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] net: fsl_pq_mdio: use dev_err_probe
  2025-07-25  5:56 [PATCH 1/1] net: fsl_pq_mdio: use dev_err_probe Alexander Stein
@ 2025-07-26 17:34 ` Simon Horman
  2025-07-26 18:40 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2025-07-26 17:34 UTC (permalink / raw)
  To: Alexander Stein
  Cc: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, netdev, linux-kernel

On Fri, Jul 25, 2025 at 07:56:13AM +0200, Alexander Stein wrote:
> Silence deferred probes using dev_err_probe(). This can happen when
> the ethernet PHY uses an IRQ line attached to a i2c GPIO expander. If the
> i2c bus is not yet ready, a probe deferral can occur.
> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>

Reviewed-by: Simon Horman <horms@kernel.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] net: fsl_pq_mdio: use dev_err_probe
  2025-07-25  5:56 [PATCH 1/1] net: fsl_pq_mdio: use dev_err_probe Alexander Stein
  2025-07-26 17:34 ` Simon Horman
@ 2025-07-26 18:40 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-07-26 18:40 UTC (permalink / raw)
  To: Alexander Stein
  Cc: andrew+netdev, davem, edumazet, kuba, pabeni, netdev,
	linux-kernel

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Fri, 25 Jul 2025 07:56:13 +0200 you wrote:
> Silence deferred probes using dev_err_probe(). This can happen when
> the ethernet PHY uses an IRQ line attached to a i2c GPIO expander. If the
> i2c bus is not yet ready, a probe deferral can occur.
> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
>  drivers/net/ethernet/freescale/fsl_pq_mdio.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Here is the summary with links:
  - [1/1] net: fsl_pq_mdio: use dev_err_probe
    https://git.kernel.org/netdev/net-next/c/5737383faea3

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-07-26 18:40 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-25  5:56 [PATCH 1/1] net: fsl_pq_mdio: use dev_err_probe Alexander Stein
2025-07-26 17:34 ` Simon Horman
2025-07-26 18:40 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).