[PATCH net-next] selftests: bpf: fix legacy netfilter options

[PATCH net-next] selftests: bpf: fix legacy netfilter options

[Jakub Kicinski]

Recent commit to add NETFILTER_XTABLES_LEGACY missed setting
a couple of configs to y. They are still enabled but as modules
which appears to have upset BPF CI, e.g.:

   test_bpf_nf_ct:FAIL:iptables-legacy -t raw -A PREROUTING -j CONNMARK --set-mark 42/0 unexpected error: 768 (errno 0)

Fixes: 3c3ab65f00eb ("selftests: net: Enable legacy netfilter legacy options.")
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
Targeting net-next 'cause that's where the bad commit is.

CC: ast@kernel.org
CC: daniel@iogearbox.net
CC: andrii@kernel.org
CC: martin.lau@linux.dev
CC: eddyz87@gmail.com
CC: song@kernel.org
CC: yonghong.song@linux.dev
CC: john.fastabend@gmail.com
CC: kpsingh@kernel.org
CC: sdf@fomichev.me
CC: haoluo@google.com
CC: jolsa@kernel.org
CC: mykolal@fb.com
CC: shuah@kernel.org
CC: pablo@netfilter.org
CC: bigeasy@linutronix.de
CC: fw@strlen.de
CC: bpf@vger.kernel.org
CC: linux-kselftest@vger.kernel.org
---
 tools/testing/selftests/bpf/config | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/testing/selftests/bpf/config b/tools/testing/selftests/bpf/config
index 521836776733..e8c6c77b96cb 100644
--- a/tools/testing/selftests/bpf/config
+++ b/tools/testing/selftests/bpf/config
@@ -97,6 +97,8 @@ CONFIG_NF_TABLES_NETDEV=y
 CONFIG_NF_TABLES_IPV4=y
 CONFIG_NF_TABLES_IPV6=y
 CONFIG_NETFILTER_INGRESS=y
+CONFIG_IP_NF_IPTABLES_LEGACY=y
+CONFIG_IP6_NF_IPTABLES_LEGACY=y
 CONFIG_NETFILTER_XTABLES_LEGACY=y
 CONFIG_NF_FLOW_TABLE=y
 CONFIG_NF_FLOW_TABLE_INET=y
-- 
2.50.1

Re: [PATCH net-next] selftests: bpf: fix legacy netfilter options

[Daniel Borkmann]

On 7/26/25 5:53 PM, Jakub Kicinski wrote:
> Recent commit to add NETFILTER_XTABLES_LEGACY missed setting
> a couple of configs to y. They are still enabled but as modules
> which appears to have upset BPF CI, e.g.:
> 
>     test_bpf_nf_ct:FAIL:iptables-legacy -t raw -A PREROUTING -j CONNMARK --set-mark 42/0 unexpected error: 768 (errno 0)
> 
> Fixes: 3c3ab65f00eb ("selftests: net: Enable legacy netfilter legacy options.")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Acked-by: Daniel Borkmann <daniel@iogearbox.net>

Re: [PATCH net-next] selftests: bpf: fix legacy netfilter options

[Jakub Kicinski]

On Sat, 26 Jul 2025 20:54:33 +0200 Daniel Borkmann wrote:
> On 7/26/25 5:53 PM, Jakub Kicinski wrote:
> > Recent commit to add NETFILTER_XTABLES_LEGACY missed setting
> > a couple of configs to y. They are still enabled but as modules
> > which appears to have upset BPF CI, e.g.:
> > 
> >     test_bpf_nf_ct:FAIL:iptables-legacy -t raw -A PREROUTING -j CONNMARK --set-mark 42/0 unexpected error: 768 (errno 0)
> > 
> > Fixes: 3c3ab65f00eb ("selftests: net: Enable legacy netfilter legacy options.")
> > Signed-off-by: Jakub Kicinski <kuba@kernel.org>  
> 
> Acked-by: Daniel Borkmann <daniel@iogearbox.net>

Thank you for the quick ack!

Re: [PATCH net-next] selftests: bpf: fix legacy netfilter options

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Sat, 26 Jul 2025 08:53:49 -0700 you wrote:
> Recent commit to add NETFILTER_XTABLES_LEGACY missed setting
> a couple of configs to y. They are still enabled but as modules
> which appears to have upset BPF CI, e.g.:
> 
>    test_bpf_nf_ct:FAIL:iptables-legacy -t raw -A PREROUTING -j CONNMARK --set-mark 42/0 unexpected error: 768 (errno 0)
> 
> Fixes: 3c3ab65f00eb ("selftests: net: Enable legacy netfilter legacy options.")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> 
> [...]

Here is the summary with links:
  - [net-next] selftests: bpf: fix legacy netfilter options
    https://git.kernel.org/netdev/net-next/c/38b74b212a34

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html