Re: [PATCH RESEND net-next v2] net: enetc: Remove error print for devm_add_action_or_reset()

Joe Damato
2025-08-12T18:17:23Z

On Tue, Aug 12, 2025 at 02:13:58PM +0200, Waqar Hameed wrote:
> When `devm_add_action_or_reset()` fails, it is due to a failed memory
> allocation and will thus return `-ENOMEM`. `dev_err_probe()` doesn't do
> anything when error is `-ENOMEM`. Therefore, remove the useless call to
> `dev_err_probe()` when `devm_add_action_or_reset()` fails, and just
> return the value instead.
>
> Signed-off-by: Waqar Hameed <waqar.hameed@axis.com>
> ---
> Changes in v2:
>
> * Split the patch to one seperate patch for each sub-system.
>
> Link to v1: https://lore.kernel.org/all/pnd7c0s6ji2.fsf@axis.com/
>
> drivers/net/ethernet/freescale/enetc/enetc4_pf.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/freescale/enetc/enetc4_pf.c b/drivers/net/ethernet/freescale/enetc/enetc4_pf.c
> index b3dc1afeefd1..38fb81db48c2 100644
> --- a/drivers/net/ethernet/freescale/enetc/enetc4_pf.c
> +++ b/drivers/net/ethernet/freescale/enetc/enetc4_pf.c
> @@ -1016,8 +1016,7 @@ static int enetc4_pf_probe(struct pci_dev *pdev,
>
> err = devm_add_action_or_reset(dev, enetc4_pci_remove, pdev);
> if (err)
> - return dev_err_probe(dev, err,
> - "Add enetc4_pci_remove() action failed\n");
> + return err;

I looked at a couple other drivers that use devm_add_action_or_reset and most
follow the pattern proposed by this change.

Reviewed-by: Joe Damato <joe@dama.to>