* [PATCH net v2] net/mlx5: Not returning mlx5_link_info table when speed is unknown
@ 2025-09-10 0:37 Li Tian
2025-09-11 6:22 ` Tariq Toukan
2025-09-12 1:40 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Li Tian @ 2025-09-10 0:37 UTC (permalink / raw)
To: netdev, linux-hyperv
Cc: Saeed Mahameed, Tariq Toukan, Mark Bloch, Leon Romanovsky,
Haiyang Zhang, Benjamin Poirier, Vitaly Kuznetsov,
Carolina Jubran, Shahar Shitrit
Because mlx5e_link_info and mlx5e_ext_link_info have holes
e.g. Azure mlx5 reports PTYS 19. Do not return it unless speed
is retrieved successfully.
Fixes: 65a5d35571849 ("net/mlx5: Refactor link speed handling with mlx5_link_info struct")
Suggested-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Signed-off-by: Li Tian <litian@redhat.com>
---
v2:
- Fix indentation and spacing only.
v1: https://lore.kernel.org/netdev/20250908085313.18768-1-litian@redhat.com
---
drivers/net/ethernet/mellanox/mlx5/core/port.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/port.c b/drivers/net/ethernet/mellanox/mlx5/core/port.c
index 2d7adf7444ba..aa9f2b0a77d3 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/port.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/port.c
@@ -1170,7 +1170,11 @@ const struct mlx5_link_info *mlx5_port_ptys2info(struct mlx5_core_dev *mdev,
mlx5e_port_get_link_mode_info_arr(mdev, &table, &max_size,
force_legacy);
i = find_first_bit(&temp, max_size);
- if (i < max_size)
+
+ /* mlx5e_link_info has holes. Check speed
+ * is not zero as indication of one.
+ */
+ if (i < max_size && table[i].speed)
return &table[i];
return NULL;
--
2.50.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net v2] net/mlx5: Not returning mlx5_link_info table when speed is unknown
2025-09-10 0:37 [PATCH net v2] net/mlx5: Not returning mlx5_link_info table when speed is unknown Li Tian
@ 2025-09-11 6:22 ` Tariq Toukan
2025-09-12 1:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Tariq Toukan @ 2025-09-11 6:22 UTC (permalink / raw)
To: Li Tian, netdev, linux-hyperv
Cc: Saeed Mahameed, Tariq Toukan, Mark Bloch, Leon Romanovsky,
Haiyang Zhang, Benjamin Poirier, Vitaly Kuznetsov,
Carolina Jubran, Shahar Shitrit
On 10/09/2025 3:37, Li Tian wrote:
> Because mlx5e_link_info and mlx5e_ext_link_info have holes
> e.g. Azure mlx5 reports PTYS 19. Do not return it unless speed
> is retrieved successfully.
>
> Fixes: 65a5d35571849 ("net/mlx5: Refactor link speed handling with mlx5_link_info struct")
> Suggested-by: Vitaly Kuznetsov <vkuznets@redhat.com>
> Signed-off-by: Li Tian <litian@redhat.com>
> ---
> v2:
> - Fix indentation and spacing only.
> v1: https://lore.kernel.org/netdev/20250908085313.18768-1-litian@redhat.com
> ---
> drivers/net/ethernet/mellanox/mlx5/core/port.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/port.c b/drivers/net/ethernet/mellanox/mlx5/core/port.c
> index 2d7adf7444ba..aa9f2b0a77d3 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/port.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/port.c
> @@ -1170,7 +1170,11 @@ const struct mlx5_link_info *mlx5_port_ptys2info(struct mlx5_core_dev *mdev,
> mlx5e_port_get_link_mode_info_arr(mdev, &table, &max_size,
> force_legacy);
> i = find_first_bit(&temp, max_size);
> - if (i < max_size)
> +
> + /* mlx5e_link_info has holes. Check speed
> + * is not zero as indication of one.
> + */
> + if (i < max_size && table[i].speed)
> return &table[i];
>
> return NULL;
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net v2] net/mlx5: Not returning mlx5_link_info table when speed is unknown
2025-09-10 0:37 [PATCH net v2] net/mlx5: Not returning mlx5_link_info table when speed is unknown Li Tian
2025-09-11 6:22 ` Tariq Toukan
@ 2025-09-12 1:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-09-12 1:40 UTC (permalink / raw)
To: Li Tian
Cc: netdev, linux-hyperv, saeedm, tariqt, mbloch, leon, haiyangz,
bpoirier, vkuznets, cjubran, shshitrit
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 10 Sep 2025 08:37:32 +0800 you wrote:
> Because mlx5e_link_info and mlx5e_ext_link_info have holes
> e.g. Azure mlx5 reports PTYS 19. Do not return it unless speed
> is retrieved successfully.
>
> Fixes: 65a5d35571849 ("net/mlx5: Refactor link speed handling with mlx5_link_info struct")
> Suggested-by: Vitaly Kuznetsov <vkuznets@redhat.com>
> Signed-off-by: Li Tian <litian@redhat.com>
>
> [...]
Here is the summary with links:
- [net,v2] net/mlx5: Not returning mlx5_link_info table when speed is unknown
https://git.kernel.org/netdev/net/c/5577352b5583
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-09-12 1:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-10 0:37 [PATCH net v2] net/mlx5: Not returning mlx5_link_info table when speed is unknown Li Tian
2025-09-11 6:22 ` Tariq Toukan
2025-09-12 1:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).