From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out30-112.freemail.mail.aliyun.com (out30-112.freemail.mail.aliyun.com [115.124.30.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06222258ECE for ; Fri, 19 Sep 2025 05:42:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=115.124.30.112 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758260579; cv=none; b=cFZLCW7AHqbMRlSi6OJFBlv64A2HEr/irGtgoFdNeIpXVS+aM41mQH5VDCd7XouSxMAxkCoNmllpdUPN4+AQ05rgoaFD1om/cvbyywEbgK95vxejQDCmen9YbTwWATubGXJanZLHvxOYMz527Crn2HmlZdM3jWgQ9yA/BMq0zf4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758260579; c=relaxed/simple; bh=5ireFOLza4n+CYFr5LY6rKuquQUmlnwwbFA/iusmRT4=; h=Message-ID:Subject:Date:From:To:Cc:References:In-Reply-To; b=Zp1HbyAYhV2TgC/HmixAccRUKkr1tYau9Yd+3N/qtgqAvI+jGXTuEBLl1EeJqS22q84/0MeRGSy6LPNkGEM+BZ1TI4kSGTM9oYnAUEx7MZEUxY++sCMs6gwJwlzzEAT65NdT+pQVxvV9NwCKUVFXVj2EMm2YmACerQZ38uyYTYw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com; spf=pass smtp.mailfrom=linux.alibaba.com; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b=E0IEQt4T; arc=none smtp.client-ip=115.124.30.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b="E0IEQt4T" DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1758260571; h=Message-ID:Subject:Date:From:To; bh=31i16PeWzKZy9H0XtrxI0I0C7x07sy/XgpoUTU+m3Vg=; b=E0IEQt4T0m/NyB0k1ZVFVvJKXilhUVXgVi+Amv8sI8fpAuCKjurupzjTk+veG34HpphDc6MbjRFJhTgtZ5GIhXbid6hyKwdFHAvqpRbtIv8+CEc98RT1pTb7yapslW09Ik98LLI5ceKXmtqIFWCkrUaKwr55E7rOiwFNObORAgQ= Received: from localhost(mailfrom:xuanzhuo@linux.alibaba.com fp:SMTPD_---0WoIgy.m_1758260568 cluster:ay36) by smtp.aliyun-inc.com; Fri, 19 Sep 2025 13:42:49 +0800 Message-ID: <1758260547.6875136-1-xuanzhuo@linux.alibaba.com> Subject: Re: [PATCH net-next v3] eea: Add basic driver framework for Alibaba Elastic Ethernet Adaptor Date: Fri, 19 Sep 2025 13:42:27 +0800 From: Xuan Zhuo To: Troy Mitchell Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Wen Gu , Philo Lu , Lorenzo Bianconi , Vadim Fedorenko , Lukas Bulwahn , Geert Uytterhoeven , Vivian Wang , Troy Mitchell , Dust Li , netdev@vger.kernel.org References: <20250919014856.20267-1-xuanzhuo@linux.alibaba.com> In-Reply-To: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: On Fri, 19 Sep 2025 09:53:57 +0800, Troy Mitchell wrote: > On Fri, Sep 19, 2025 at 09:48:56AM +0800, Xuan Zhuo wrote: > > Add a driver framework for EEA that will be available in the future. > > > > This driver is currently quite minimal, implementing only fundamental > > core functionalities. Key features include: I/O queue management via > > adminq, basic PCI-layer operations, and essential RX/TX data > > communication capabilities. It also supports the creation, > > initialization, and management of network devices (netdev). Furthermore, > > the ring structures for both I/O queues and adminq have been abstracted > > into a simple, unified, and reusable library implementation, > > facilitating future extension and maintenance. > > > > This commit is indeed quite large, but further splitting it would not be > > meaningful. Historically, many similar drivers have been introduced with > > commits of similar size and scope, so we chose not to invest excessive > > effort into finer-grained splitting. > Maybe this note should go below the `---` > - Troy Yes, will fix. Thanks > > > > Reviewed-by: Dust Li > > Reviewed-by: Philo Lu > > Signed-off-by: Wen Gu > > Signed-off-by: Xuan Zhuo