From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E827533D8; Sat, 20 Sep 2025 00:10:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758327007; cv=none; b=jJfiTWhKB0ZLoVNFowvGpCBcgN9TB2SUAwOQP2Q5DJ39IQJ5qm8sClqHR85VTjI0yGwjXowWf7A/WVlrTuYTF+Es9qnUuQJSh4ZfgxzA1GLvibKPRgNXrRFiqfLa5xnApuFNhWgln0q5lwKi8kOS6umuqDklP9IkN9IXp8WxW6Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758327007; c=relaxed/simple; bh=JkPWbXg69iqhHJ900MWi2o+UGPJDKtEJ6OfUOR2VnvU=; h=Content-Type:MIME-Version:Subject:From:Message-Id:Date:References: In-Reply-To:To:Cc; b=kNrIVM+1SRetFDtTZY62ovV/iYc6Djx1jUVB/966/1HYM/EwxUD5DIp2483Bk4fBHF2KNj2ciDvr51CFol2eILoHp1lUvIKWh7HD9Ri2Y1gPQ8pKzTRrCOLKmTHEU5qFuW2QSNtqhqN9t+20kOgEpWwXxGz8fU84Xo7HG8LuJaY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=O6o/BW0f; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="O6o/BW0f" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 76931C4CEF0; Sat, 20 Sep 2025 00:10:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1758327006; bh=JkPWbXg69iqhHJ900MWi2o+UGPJDKtEJ6OfUOR2VnvU=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=O6o/BW0f+45gy85lsSLjU/GGU1Ffl/8HM1Hzm3G6DtcQnrAitBE5cylJWjovMWmd2 wodY0mkQFvBGjUNoXLW1szKmFA7pRRGitzepybn++o8eggPDz610EuRWH/wLDM2xHL 9e24r09owmVp4Y+4zq2ZzETxFMxerIMWbyP6ORsbPndLvZMpiCXim7AnGYyLglEDZF dw7iDFdcFXT8BKiNelca1APnGtfdKQk8DMW5tXuulsMMw3bSq9wJ7jFK21DWkJZMz1 97ijZXCoES4sZBqRc7NBtVUcMeqg5PD4W4KhC60gv0M502895rRuGZTC6wPklKvEC3 jR8F4T1xEkRVQ== Received: from [10.30.226.235] (localhost [IPv6:::1]) by aws-us-west-2-korg-oddjob-rhel9-1.codeaurora.org (Postfix) with ESMTP id EB07F39D0C20; Sat, 20 Sep 2025 00:10:06 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH net-next] net: ti: icssm-prueth: unwind cleanly in probe() From: patchwork-bot+netdevbpf@kernel.org Message-Id: <175832700584.3744610.12963791321568877888.git-patchwork-notify@kernel.org> Date: Sat, 20 Sep 2025 00:10:05 +0000 References: In-Reply-To: To: Dan Carpenter Cc: rogerq@ti.com, danishanwar@ti.com, parvathi@couthit.com, rogerq@kernel.org, pmohan@couthit.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, basharath@couthit.com, afd@ti.com, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski : On Thu, 18 Sep 2025 12:48:26 +0300 you wrote: > This error handling triggers a Smatch warning: > > drivers/net/ethernet/ti/icssm/icssm_prueth.c:1574 icssm_prueth_probe() > warn: 'prueth->pru1' is an error pointer or valid > > The warning is harmless because the pru_rproc_put() function has an > IS_ERR_OR_NULL() check built in. However, there is a small bug if > syscon_regmap_lookup_by_phandle() fails. In that case we should call > of_node_put() on eth0_node and eth1_node. > > [...] Here is the summary with links: - [net-next] net: ti: icssm-prueth: unwind cleanly in probe() https://git.kernel.org/netdev/net-next/c/5fc7fa743dbf You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html