From: Stephen Boyd <sboyd@kernel.org>
To: Matthew Gerlach <matthew.gerlach@altera.com>,
dinguyen@kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, mturquette@baylibre.com,
netdev@vger.kernel.org, richardcochran@gmail.com
Cc: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>,
Teh Wen Ping <wen.ping.teh@intel.com>
Subject: Re: [PATCH v5] clk: socfpga: agilex: add support for the Intel Agilex5
Date: Sun, 21 Sep 2025 10:59:51 -0700 [thread overview]
Message-ID: <175847759120.4354.5284082297601743277@lazor> (raw)
In-Reply-To: <7dd9bca2-6c09-4067-b3f8-9bdc10dea39f@altera.com>
Quoting Matthew Gerlach (2025-07-02 09:04:17)
> On 6/30/25 6:05 PM, Stephen Boyd wrote:
> > Quoting Matthew Gerlach (2025-05-13 16:48:37)
> > > @@ -334,6 +336,375 @@ static const struct stratix10_gate_clock agilex_gate_clks[] = {
> > > 10, 0, 0, 0, 0, 0, 4},
> > > };
> > >
> > > +static const struct clk_parent_data agilex5_pll_mux[] = {
> > > + { .name = "osc1", },
> > > + { .name = "cb-intosc-hs-div2-clk", },
> > > + { .name = "f2s-free-clk", },
> >
> > Please don't use clk_parent_data with only .name set with dot
> > initializers. This is actually { .index = 0, .name = "..." } which means
> > the core is looking at the DT node for the first index of the 'clocks'
> If the core should be looking for the first index of the 'clocks'
> property, is it better to explicitly to state ".index = 0" or just have
> the name?
Be explicit with '.index = 0' and don't have a '.name' member.
prev parent reply other threads:[~2025-09-21 17:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-13 23:48 [PATCH v5] clk: socfpga: agilex: add support for the Intel Agilex5 Matthew Gerlach
2025-06-09 16:53 ` Matthew Gerlach
2025-06-17 16:21 ` Matthew Gerlach
2025-07-01 1:05 ` Stephen Boyd
2025-07-02 16:04 ` Matthew Gerlach
2025-09-21 17:59 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175847759120.4354.5284082297601743277@lazor \
--to=sboyd@kernel.org \
--cc=dinguyen@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.gerlach@altera.com \
--cc=mturquette@baylibre.com \
--cc=netdev@vger.kernel.org \
--cc=niravkumar.l.rabara@intel.com \
--cc=richardcochran@gmail.com \
--cc=wen.ping.teh@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox