From: Stephen Boyd <sboyd@kernel.org>
To: "Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"Andy Yan" <andy.yan@rock-chips.com>,
"Bill Wendling" <morbo@google.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Chanwoo Choi" <cw00.choi@samsung.com>,
"David Airlie" <airlied@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Heiko Stuebner" <heiko@sntech.de>,
"Jaehoon Chung" <jh80.chung@samsung.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Jaroslav Kysela" <perex@perex.cz>,
"Justin Stitt" <justinstitt@google.com>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Kyungmin Park" <kyungmin.park@samsung.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Mark Brown" <broonie@kernel.org>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Michael Turquette" <mturquette@baylibre.com>,
"MyungJoo Ham" <myungjoo.ham@samsung.com>,
"Nathan Chancellor" <nathan@kernel.org>,
"Nick Desaulniers" <nick.desaulniers+lkml@gmail.com>,
"Nicolas Frattaroli" <frattaroli.nicolas@gmail.com>,
"Nicolas Frattaroli" <nicolas.frattaroli@collabora.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Qin Jian" <qinjian@cqplus1.com>,
"Rasmus Villemoes" <linux@rasmusvillemoes.dk>,
"Rob Herring" <robh@kernel.org>,
"Sandy Huang" <hjc@rock-chips.com>,
"Shawn Lin" <shawn.lin@rock-chips.com>,
"Shreeya Patel" <shreeya.patel@collabora.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Takashi Iwai" <tiwai@suse.com>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
"Vinod Koul" <vkoul@kernel.org>,
"Yury Norov" <yury.norov@gmail.com>
Cc: kernel@collabora.com, linux-kernel@vger.kernel.org,
linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-media@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-phy@lists.infradead.org,
linux-sound@vger.kernel.org, netdev@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-pci@vger.kernel.org, linux-pm@vger.kernel.org,
linux-clk@vger.kernel.org, llvm@lists.linux.dev,
Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
Subject: Re: [PATCH v2 19/20] clk: sp7021: switch to FIELD_PREP_WM16 macro
Date: Sun, 21 Sep 2025 13:04:19 -0700 [thread overview]
Message-ID: <175848505982.4354.2243738737036950081@lazor> (raw)
In-Reply-To: <20250623-byeword-update-v2-19-cf1fc08a2e1f@collabora.com>
Quoting Nicolas Frattaroli (2025-06-23 09:05:47)
> The sp7021 clock driver has its own shifted high word mask macro,
> similar to the ones many Rockchip drivers have.
>
> Remove it, and replace instances of it with hw_bitfield.h's
> FIELD_PREP_WM16 macro, which does the same thing except in a common
> macro that also does compile-time error checking.
>
> This was compile-tested with 32-bit ARM with Clang, no runtime tests
> were performed as I lack the hardware. However, I verified that fix
> commit 5c667d5a5a3e ("clk: sp7021: Adjust width of _m in HWM_FIELD_PREP()")
> is not regressed. No warning is produced.
>
> Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
> ---
Acked-by: Stephen Boyd <sboyd@kernel.org>
next prev parent reply other threads:[~2025-09-21 20:04 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-23 16:05 [PATCH v2 00/20] BYEWORD_UPDATE: unifying (most) HIWORD_UPDATE macros Nicolas Frattaroli
2025-06-23 16:05 ` [PATCH v2 01/20] bitmap: introduce hardware-specific bitfield operations Nicolas Frattaroli
2025-06-23 16:05 ` [PATCH v2 02/20] mmc: dw_mmc-rockchip: switch to FIELD_PREP_WM16 macro Nicolas Frattaroli
2025-06-23 16:05 ` [PATCH v2 03/20] soc: rockchip: grf: switch to FIELD_PREP_WM16_CONST macro Nicolas Frattaroli
2025-06-23 16:05 ` [PATCH v2 04/20] media: synopsys: hdmirx: replace macros with bitfield variants Nicolas Frattaroli
2025-06-23 16:05 ` [PATCH v2 05/20] drm/rockchip: lvds: switch to FIELD_PREP_WM16 macro Nicolas Frattaroli
2025-06-23 16:05 ` [PATCH v2 06/20] phy: rockchip-emmc: " Nicolas Frattaroli
2025-06-23 16:05 ` [PATCH v2 07/20] drm/rockchip: dsi: switch to FIELD_PREP_WM16* macros Nicolas Frattaroli
2025-06-23 16:05 ` [PATCH v2 08/20] drm/rockchip: vop2: switch to FIELD_PREP_WM16 macro Nicolas Frattaroli
2025-06-23 16:05 ` [PATCH v2 09/20] phy: rockchip-samsung-dcphy: " Nicolas Frattaroli
2025-06-23 16:05 ` [PATCH v2 10/20] drm/rockchip: dw_hdmi_qp: " Nicolas Frattaroli
2025-06-23 16:05 ` [PATCH v2 11/20] drm/rockchip: inno-hdmi: " Nicolas Frattaroli
2025-06-23 16:05 ` [PATCH v2 12/20] phy: rockchip-usb: " Nicolas Frattaroli
2025-06-23 16:05 ` [PATCH v2 13/20] drm/rockchip: dw_hdmi: switch to FIELD_PREP_WM16* macros Nicolas Frattaroli
2025-06-23 16:05 ` [PATCH v2 14/20] ASoC: rockchip: i2s-tdm: switch to FIELD_PREP_WM16_CONST macro Nicolas Frattaroli
2025-06-23 16:05 ` [PATCH v2 15/20] net: stmmac: dwmac-rk: switch to FIELD_PREP_WM16 macro Nicolas Frattaroli
2025-06-23 16:05 ` [PATCH v2 16/20] PCI: rockchip: Switch to FIELD_PREP_WM16* macros Nicolas Frattaroli
2025-06-23 16:05 ` [PATCH v2 17/20] PCI: dw-rockchip: Switch to FIELD_PREP_WM16 macro Nicolas Frattaroli
2025-06-23 16:05 ` [PATCH v2 18/20] PM / devfreq: rockchip-dfi: switch " Nicolas Frattaroli
2025-06-23 16:05 ` [PATCH v2 19/20] clk: sp7021: " Nicolas Frattaroli
2025-07-25 1:14 ` Stephen Boyd
2025-08-25 7:48 ` Nicolas Frattaroli
2025-09-21 20:04 ` Stephen Boyd [this message]
2025-06-23 16:05 ` [PATCH v2 20/20] phy: rockchip-pcie: " Nicolas Frattaroli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175848505982.4354.2243738737036950081@lazor \
--to=sboyd@kernel.org \
--cc=airlied@gmail.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=andy.yan@rock-chips.com \
--cc=bhelgaas@google.com \
--cc=broonie@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=davem@davemloft.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=edumazet@google.com \
--cc=frattaroli.nicolas@gmail.com \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=jh80.chung@samsung.com \
--cc=justinstitt@google.com \
--cc=kernel@collabora.com \
--cc=kishon@kernel.org \
--cc=kuba@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux@rasmusvillemoes.dk \
--cc=llvm@lists.linux.dev \
--cc=lpieralisi@kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mani@kernel.org \
--cc=mchehab@kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=morbo@google.com \
--cc=mripard@kernel.org \
--cc=mturquette@baylibre.com \
--cc=myungjoo.ham@samsung.com \
--cc=nathan@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=nicolas.frattaroli@collabora.com \
--cc=pabeni@redhat.com \
--cc=perex@perex.cz \
--cc=qinjian@cqplus1.com \
--cc=robh@kernel.org \
--cc=shawn.lin@rock-chips.com \
--cc=shreeya.patel@collabora.com \
--cc=simona@ffwll.ch \
--cc=tiwai@suse.com \
--cc=tzimmermann@suse.de \
--cc=ulf.hansson@linaro.org \
--cc=vkoul@kernel.org \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox