From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A55B229B38; Sun, 21 Sep 2025 20:04:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758485062; cv=none; b=KfLkcrgOP4T97uynh7avtaN83EIA7YuGtGdyvR1xRdJnoTWrT1NfFnsS92heXNBXBtL+mmg6cpl6aG2F1XTw0tSWrjFAB2yvKGRYUnXFU103mZQ0tJQObL23+bvqX1KBPd+Iu4EVjH9rcsbsuZvOinKjl7zA000p0geo1Kdmb9g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758485062; c=relaxed/simple; bh=oK6PNMhjBQuguBf6ZyCDvGmGsPBZFWxojb6mTU595d4=; h=Content-Type:MIME-Version:In-Reply-To:References:Subject:From:Cc: To:Date:Message-ID; b=AaRp6PBxilph9v1Uvhr1LOETbN1w7tT9hWUoBmM6DBY+lZzqWufW3TIY7TMee/JE9tOKMsJzwVfCL6DWne9g4Rthqwq1sRtnvshjSiPUPDH7kRZXxOu2aJ4qKVOHE2un1cF9kDy4f5iZtuH1HSpT9mjfoBdqDJZIWg7LTVM0BEc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=iCTBvx1y; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="iCTBvx1y" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5A835C4CEE7; Sun, 21 Sep 2025 20:04:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1758485061; bh=oK6PNMhjBQuguBf6ZyCDvGmGsPBZFWxojb6mTU595d4=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=iCTBvx1ycWtFaxbFJjKnE8lmTRV6YKBljeoNPWr3O0f9KOI2wK+gY/chvSLppb2iw nKDM1jLs/kX3EvgUACM5BKR1e32v5rVmusbFg6REu8gh8nHtL4KnpR4cztPIEWYsyn 85sV5ZWf8I2axh1P00A55pSPIoljTkKeShL0Yo6iD75KN1B4tcxd0MZkgqGmYUT1mQ IpOfY2l2pbjRNsgwxsBcIB9YfzgZxcgmX2t0tM84PDIkYUJsgjzu0i/zQZHS16n4gv WrApdIyoKSa91FOKnNUjwHaVFh7bF8WfL1saxL8xffSMJav7UkpqNUB9WhDh8//gHr V8yFvFNiMSeTQ== Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20250623-byeword-update-v2-19-cf1fc08a2e1f@collabora.com> References: <20250623-byeword-update-v2-0-cf1fc08a2e1f@collabora.com> <20250623-byeword-update-v2-19-cf1fc08a2e1f@collabora.com> Subject: Re: [PATCH v2 19/20] clk: sp7021: switch to FIELD_PREP_WM16 macro From: Stephen Boyd Cc: kernel@collabora.com, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-pci@vger.kernel.org, linux-pm@vger.kernel.org, linux-clk@vger.kernel.org, llvm@lists.linux.dev, Nicolas Frattaroli To: Alexandre Torgue , Andrew Lunn , Andy Yan , Bill Wendling , Bjorn Helgaas , Chanwoo Choi , David Airlie , David S. Miller , Eric Dumazet , Heiko Stuebner , Jaehoon Chung , Jakub Kicinski , Jaroslav Kysela , Justin Stitt , Kishon Vijay Abraham I , Krzysztof =?utf-8?q?Wilczy=C5=84ski?= , Kyungmin Park , Liam Girdwood , Lorenzo Pieralisi , Maarten Lankhorst , Manivannan Sadhasivam , Mark Brown , Mauro Carvalho Chehab , Maxime Coquelin , Maxime Ripard , Michael Turquette , MyungJoo Ham , Nathan Chancellor , Nick Desaulniers , Nicolas Frattaroli , Nicolas Frattaroli , Paolo Abeni , Qin Jian , Rasmus Villemoes , Rob Herring , Sandy Huang , Shawn Lin , Shreeya Patel , Simona Vetter , Takashi Iwai , Thomas Zimmermann , Ulf Hansson , Vinod Koul , Yury Norov Date: Sun, 21 Sep 2025 13:04:19 -0700 Message-ID: <175848505982.4354.2243738737036950081@lazor> User-Agent: alot/0.11 Quoting Nicolas Frattaroli (2025-06-23 09:05:47) > The sp7021 clock driver has its own shifted high word mask macro, > similar to the ones many Rockchip drivers have. >=20 > Remove it, and replace instances of it with hw_bitfield.h's > FIELD_PREP_WM16 macro, which does the same thing except in a common > macro that also does compile-time error checking. >=20 > This was compile-tested with 32-bit ARM with Clang, no runtime tests > were performed as I lack the hardware. However, I verified that fix > commit 5c667d5a5a3e ("clk: sp7021: Adjust width of _m in HWM_FIELD_PREP()= ") > is not regressed. No warning is produced. >=20 > Signed-off-by: Nicolas Frattaroli > --- Acked-by: Stephen Boyd