* [PATCH v2 net-next] dpll: zl3073x: Fix double free in zl3073x_devlink_flash_update()
@ 2025-09-25 13:28 Dan Carpenter
2025-09-25 13:44 ` Vadim Fedorenko
2025-09-26 22:40 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2025-09-25 13:28 UTC (permalink / raw)
To: Ivan Vecera
Cc: Prathosh Satish, Vadim Fedorenko, Arkadiusz Kubalewski,
Jiri Pirko, Przemek Kitszel, Jakub Kicinski, netdev, linux-kernel,
kernel-janitors
The zl3073x_devlink_flash_prepare() function calls zl3073x_fw_free() and
the caller, zl3073x_devlink_flash_update(), also calls that same free
function so it leads to a double free. Delete the extra free.
Fixes: a1e891fe4ae8 ("dpll: zl3073x: Implement devlink flash callback")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Simon Horman <horms@kernel.org>
Reviewed-by: Ivan Vecera <ivecera@redhat.com>
---
v2: Fix the commit message. Words in wrong order == nonsense.
drivers/dpll/zl3073x/devlink.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/dpll/zl3073x/devlink.c b/drivers/dpll/zl3073x/devlink.c
index f55d5309d4f9..ccc22332b346 100644
--- a/drivers/dpll/zl3073x/devlink.c
+++ b/drivers/dpll/zl3073x/devlink.c
@@ -167,7 +167,6 @@ zl3073x_devlink_flash_prepare(struct zl3073x_dev *zldev,
zl3073x_devlink_flash_notify(zldev,
"Utility is missing in firmware",
NULL, 0, 0);
- zl3073x_fw_free(zlfw);
return -ENOEXEC;
}
--
2.51.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2 net-next] dpll: zl3073x: Fix double free in zl3073x_devlink_flash_update()
2025-09-25 13:28 [PATCH v2 net-next] dpll: zl3073x: Fix double free in zl3073x_devlink_flash_update() Dan Carpenter
@ 2025-09-25 13:44 ` Vadim Fedorenko
2025-09-26 22:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Vadim Fedorenko @ 2025-09-25 13:44 UTC (permalink / raw)
To: Dan Carpenter, Ivan Vecera
Cc: Prathosh Satish, Arkadiusz Kubalewski, Jiri Pirko,
Przemek Kitszel, Jakub Kicinski, netdev, linux-kernel,
kernel-janitors
On 25/09/2025 14:28, Dan Carpenter wrote:
> The zl3073x_devlink_flash_prepare() function calls zl3073x_fw_free() and
> the caller, zl3073x_devlink_flash_update(), also calls that same free
> function so it leads to a double free. Delete the extra free.
>
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 net-next] dpll: zl3073x: Fix double free in zl3073x_devlink_flash_update()
2025-09-25 13:28 [PATCH v2 net-next] dpll: zl3073x: Fix double free in zl3073x_devlink_flash_update() Dan Carpenter
2025-09-25 13:44 ` Vadim Fedorenko
@ 2025-09-26 22:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-09-26 22:40 UTC (permalink / raw)
To: Dan Carpenter
Cc: ivecera, Prathosh.Satish, vadim.fedorenko, arkadiusz.kubalewski,
jiri, przemyslaw.kitszel, kuba, netdev, linux-kernel,
kernel-janitors
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 25 Sep 2025 16:28:13 +0300 you wrote:
> The zl3073x_devlink_flash_prepare() function calls zl3073x_fw_free() and
> the caller, zl3073x_devlink_flash_update(), also calls that same free
> function so it leads to a double free. Delete the extra free.
>
> Fixes: a1e891fe4ae8 ("dpll: zl3073x: Implement devlink flash callback")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> Reviewed-by: Simon Horman <horms@kernel.org>
> Reviewed-by: Ivan Vecera <ivecera@redhat.com>
>
> [...]
Here is the summary with links:
- [v2,net-next] dpll: zl3073x: Fix double free in zl3073x_devlink_flash_update()
https://git.kernel.org/netdev/net-next/c/347afa390427
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-09-26 22:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-25 13:28 [PATCH v2 net-next] dpll: zl3073x: Fix double free in zl3073x_devlink_flash_update() Dan Carpenter
2025-09-25 13:44 ` Vadim Fedorenko
2025-09-26 22:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).