[PATCH net-next] net: phy: micrel: Fix lan8814_config_init

[PATCH net-next] net: phy: micrel: Fix lan8814_config_init

[Horatiu Vultur]

The blamed commit introduced the function lanphy_modify_page_reg which
as name suggests it, it modifies the registers. In the same commit we
have started to use this function inside the drivers. The problem is
that in the function lan8814_config_init we passed the wrong page number
when disabling the aneg towards host side. We passed extended page number
4(LAN8814_PAGE_COMMON_REGS) instead of extended page
5(LAN8814_PAGE_PORT_REGS)

Fixes: a0de636ed7a264 ("net: phy: micrel: Introduce lanphy_modify_page_reg")
Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>

---
this is targeting net-next and not net because the blamed commit doesn't
exist on net
---
 drivers/net/phy/micrel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
index 0b42400e5e098..79ce3eb6752b6 100644
--- a/drivers/net/phy/micrel.c
+++ b/drivers/net/phy/micrel.c
@@ -4367,7 +4367,7 @@ static int lan8814_config_init(struct phy_device *phydev)
 			       LAN8814_QSGMII_SOFT_RESET_BIT);
 
 	/* Disable ANEG with QSGMII PCS Host side */
-	lanphy_modify_page_reg(phydev, LAN8814_PAGE_COMMON_REGS,
+	lanphy_modify_page_reg(phydev, LAN8814_PAGE_PORT_REGS,
 			       LAN8814_QSGMII_PCS1G_ANEG_CONFIG,
 			       LAN8814_QSGMII_PCS1G_ANEG_CONFIG_ANEG_ENA,
 			       0);
-- 
2.34.1

Re: [PATCH net-next] net: phy: micrel: Fix lan8814_config_init

[Simon Horman]

On Thu, Sep 25, 2025 at 08:47:02AM +0200, Horatiu Vultur wrote:
> The blamed commit introduced the function lanphy_modify_page_reg which
> as name suggests it, it modifies the registers. In the same commit we
> have started to use this function inside the drivers. The problem is
> that in the function lan8814_config_init we passed the wrong page number
> when disabling the aneg towards host side. We passed extended page number
> 4(LAN8814_PAGE_COMMON_REGS) instead of extended page
> 5(LAN8814_PAGE_PORT_REGS)
> 
> Fixes: a0de636ed7a264 ("net: phy: micrel: Introduce lanphy_modify_page_reg")
> Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> 
> ---
> this is targeting net-next and not net because the blamed commit doesn't
> exist on net

Thanks, I agree that the page was changed in the cited commit.
And it seems to me that it wasn't an intentional change.

Reviewed-by: Simon Horman <horms@kernel.org>

Re: [PATCH net-next] net: phy: micrel: Fix lan8814_config_init

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Thu, 25 Sep 2025 08:47:02 +0200 you wrote:
> The blamed commit introduced the function lanphy_modify_page_reg which
> as name suggests it, it modifies the registers. In the same commit we
> have started to use this function inside the drivers. The problem is
> that in the function lan8814_config_init we passed the wrong page number
> when disabling the aneg towards host side. We passed extended page number
> 4(LAN8814_PAGE_COMMON_REGS) instead of extended page
> 5(LAN8814_PAGE_PORT_REGS)
> 
> [...]

Here is the summary with links:
  - [net-next] net: phy: micrel: Fix lan8814_config_init
    https://git.kernel.org/netdev/net-next/c/bf91f4bc9c1d

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html