From: Eric Dumazet <eric.dumazet@gmail.com>
To: Randy Dunlap <rdunlap@infradead.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>
Cc: "積丹尼 Dan Jacobson" <jidanni@jidanni.org>
Subject: Re: [PATCH net-next] TCP: make seq # error messages more readable
Date: Fri, 13 Jul 2018 06:38:45 -0700 [thread overview]
Message-ID: <175f5cd8-c242-b89b-3ca8-2dfc43e730f7@gmail.com> (raw)
In-Reply-To: <48586224-eb36-2489-735c-4946cb0b1c2b@infradead.org>
On 07/12/2018 05:48 PM, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Attempt to make cryptic TCP seq number error messages clearer by
> (1) adding the function name, (2) identifying the errors as "seq # bug",
> and (3) grouping the field identifiers and values by separating them
> with commas.
>
> E.g., the following message is changed from:
>
> recvmsg bug 2: copied 73BCB6CD seq 70F17CBE rcvnxt 73BCB9AA fl 0
> WARNING: CPU: 2 PID: 1501 at /linux/net/ipv4/tcp.c:1881 tcp_recvmsg+0x649/0xb90
>
> to:
>
> tcp_recvmsg: TCP recvmsg seq # bug 2: copied 73BCB6CD, seq 70F17CBE, rcvnxt 73BCB9AA, fl 0
> WARNING: CPU: 2 PID: 1501 at /linux/net/ipv4/tcp.c:2011 tcp_recvmsg+0x694/0xba0
>
Hi Randy
It is not clear what this patch improves.
Do we really to mention tcp twice ?
Thanks.
next prev parent reply other threads:[~2018-07-13 13:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-13 0:48 [PATCH net-next] TCP: make seq # error messages more readable Randy Dunlap
2018-07-13 13:38 ` Eric Dumazet [this message]
2018-07-13 16:48 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175f5cd8-c242-b89b-3ca8-2dfc43e730f7@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jidanni@jidanni.org \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).