From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH net-next] TCP: make seq # error messages more readable Date: Fri, 13 Jul 2018 06:38:45 -0700 Message-ID: <175f5cd8-c242-b89b-3ca8-2dfc43e730f7@gmail.com> References: <48586224-eb36-2489-735c-4946cb0b1c2b@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: =?UTF-8?B?56mN5Li55bC8IERhbiBKYWNvYnNvbg==?= To: Randy Dunlap , "netdev@vger.kernel.org" , David Miller , Eric Dumazet Return-path: Received: from mail-pf0-f196.google.com ([209.85.192.196]:34371 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729284AbeGMNx2 (ORCPT ); Fri, 13 Jul 2018 09:53:28 -0400 Received: by mail-pf0-f196.google.com with SMTP id e10-v6so22680103pfn.1 for ; Fri, 13 Jul 2018 06:38:47 -0700 (PDT) In-Reply-To: <48586224-eb36-2489-735c-4946cb0b1c2b@infradead.org> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 07/12/2018 05:48 PM, Randy Dunlap wrote: > From: Randy Dunlap > > Attempt to make cryptic TCP seq number error messages clearer by > (1) adding the function name, (2) identifying the errors as "seq # bug", > and (3) grouping the field identifiers and values by separating them > with commas. > > E.g., the following message is changed from: > > recvmsg bug 2: copied 73BCB6CD seq 70F17CBE rcvnxt 73BCB9AA fl 0 > WARNING: CPU: 2 PID: 1501 at /linux/net/ipv4/tcp.c:1881 tcp_recvmsg+0x649/0xb90 > > to: > > tcp_recvmsg: TCP recvmsg seq # bug 2: copied 73BCB6CD, seq 70F17CBE, rcvnxt 73BCB9AA, fl 0 > WARNING: CPU: 2 PID: 1501 at /linux/net/ipv4/tcp.c:2011 tcp_recvmsg+0x694/0xba0 > Hi Randy It is not clear what this patch improves. Do we really to mention tcp twice ? Thanks.